-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced sorting for numeric and alphanumeric titles #3554
Conversation
@benwbrum I opted for the approach in which at the time of Screencast.from.03-16-2023.09_18_38.PM.webm |
I don't think that ording on display is going to work, since part of the application allows project owners to manually change the order of pages within a work. (Click on a work you own; click the Pages tab) This is a feature which is not used often, but it is important for the few projects that use it. So I think that we should continue to order based on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on PR.
@benwbrum With the new changes, it will sort the pages numerically before creating them in the DB. I have tested it locally too, its working as expected now. |
f9182d0
to
b67873c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better logic than what I came up with.
Closes #2809