Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3702-Added Check For Mark As Blank On Save #3714

Merged
merged 2 commits into from
Jul 20, 2023
Merged

#3702-Added Check For Mark As Blank On Save #3714

merged 2 commits into from
Jul 20, 2023

Conversation

symmetrically
Copy link
Contributor

No description provided.

benwbrum
benwbrum requested changes Jul 19, 2023
View reviewed changes
Copy link
Owner

@benwbrum benwbrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please internationalize the confirmation message.

@benwbrum
Copy link
Owner

This works well for text transcription, but does not catch spreadsheet transcription.

I tested with http://localhost:3000/benwbrum/cosa-ledger-demo/tax-lists-pasquotank-county-1769 and did not get the warning. We should also test with field-based transcription without spreadsheets.

@benwbrum benwbrum linked an issue Jul 20, 2023 that may be closed by this pull request
"Mark Blank" checkbox can be clicked accidentally, blanking transcripts #3702
Closed
@benwbrum benwbrum merged commit ff36b2e into development Jul 20, 2023
@benwbrum benwbrum deleted the 3702-added-check-on-mark-as-blank branch October 25, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwbrum benwbrum benwbrum requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Mark Blank" checkbox can be clicked accidentally, blanking transcripts
2 participants
@symmetrically @benwbrum