Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2858 Added feature for showing contributions hours view and PDF letter download #3837

Merged
merged 7 commits into from
Nov 29, 2023

Conversation

symmetrically
Copy link
Contributor

No description provided.

@saracarl saracarl self-requested a review October 31, 2023 15:11
@saracarl saracarl linked an issue Oct 31, 2023 that may be closed by this pull request
Copy link
Owner

@benwbrum benwbrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me!

Copy link
Collaborator

@saracarl saracarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super exciting! Folks are really going to like having this.

Here's the changes the letter needs:

  1. Get rid of "figure 1: logo" under the logo:
    image

  2. Change the date from this:
    image

to the more formal:
image

  1. Can we add an extra line/carriage return after the date and before the "To Whom it May Concern"?

  2. Every place we say "From the Page" it should be "FromThePage" (my example letter was wrong on this).

  3. Dates in the text of the letter need to be formally written out as well:
    image

  4. In the table, could we give the collection name more space and the page count less space? (Maybe right justify the page counts?)
    image

  5. Let's add another carriage return after "Regards,"

  6. There should be a line break between "Sara Brumfield" and "Partner, Brumfield Labs".
    image

  7. In two places in the text, we break the words with a hyphen:
    image
    image

I'd really prefer that the word moves to the following line. (@benwbrum may have some ideas on that.)

@benwbrum
Copy link
Owner

I'm not entirely sure what to do about the line breaks with collec- -- there are a handful of options you can pass to Pandoc, so could we explore a bit?

Let's right-justify the Pages Count column and rename the header to Pages. That may give us a bit more room for the collection. (Note that we had to use a special markdown tables plugin when we run Pandoc in the work PDF export, which is passed in as a command-line argument.)

Copy link
Collaborator

@saracarl saracarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. 2 more small changes:

  1. Add a carriage return between the logo and the date.
  2. Make sure it's FromThePage, not FromthePage. (Branding!) It's wrong 2 places and correct 1 place.

Otherwise, looks good.

Copy link
Collaborator

@saracarl saracarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messages are missing:
letter (2).pdf

I would probably have added the messages to the dashboard messages file, to match the controller you're using. With your current setup, you can probably make this work by fully qualifying the message references, i.e. hours_letter.pdf.letter.certification_text

We use i18n-tasks to do a lot of this work; it makes it much easier. I'll send an email with some details about that library and our google translate key. (I probably wouldn't use it with this PR, because it requires starting over, but I would with all the ones in the future.)

@saracarl saracarl merged commit 60c17ad into development Nov 29, 2023
@saracarl saracarl deleted the 2858-feature-contribution-time branch November 29, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volunteer hours downloadable letter
3 participants