Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3053 - wrap column for long text #4137

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

atbah
Copy link
Collaborator

@atbah atbah commented May 29, 2024

Closes #3053

@atbah atbah requested a review from benwbrum May 29, 2024 19:42
@atbah
Copy link
Collaborator Author

atbah commented May 29, 2024

@benwbrum This fix involves in Handsontable's configuration. I investigated some time and added new 2 configs to wrap up the long text. But please have a test on your end and make sure if it works for both short/long columns.

@benwbrum
Copy link
Owner

That makes sense -- we'll do some more careful testing on this, then.

@benwbrum
Copy link
Owner

Atef's particular concern:

In order to wrap up the long text, I have set column's width 100px and allowed autoWrapCol.
I just wonder if 100px works for all cases.

@benwbrum
Copy link
Owner

benwbrum commented Jun 2, 2024

@atbah You were right to be cautious about the 100px. I tried this out on two collections with long (and sometimes short) column names, and found that some column headers were truncated:

Screenshot from 2024-06-01 16-11-32
Screenshot from 2024-06-01 16-11-14

These spreadsheets were configured like this:
Screenshot from 2024-06-01 16-25-25
Screenshot from 2024-06-01 16-25-17

@atbah
Copy link
Collaborator Author

atbah commented Jun 3, 2024

okay, I will investigate more and try to find the better solution.

@atbah
Copy link
Collaborator Author

atbah commented Jun 7, 2024

@benwbrum In order to wrap up long text in the column, we should set max width to column.
I tested several alternative approaches but the last commit works the best I think.
Please take a look.
image

@benwbrum benwbrum assigned benwbrum and unassigned atbah Jun 7, 2024
@benwbrum benwbrum merged commit 18f8ed3 into development Jun 7, 2024
@benwbrum benwbrum deleted the 3053-long-text-column branch June 7, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long text columns make spreadsheet view unusable
2 participants