-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3358 transcribe full screen #4151
Conversation
app/views/shared/_osd_div.html.slim
Outdated
@@ -9,6 +9,8 @@ | |||
a#osd_zoom_out =svg_symbol "#icon-zoom-out", class: 'icon' | |||
a#osd_home =svg_symbol "#icon-fit-view", class: 'icon' | |||
a#osd_fit_width(title="#{t('.fit_width')}") =svg_symbol "#icon-fit-width", class: 'icon' | |||
-if !@is_monitor_view | |||
a#osd_monitor(title="#{t('.monitor')}") =svg_symbol "#icon-window", class: 'icon' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we replace this with a "close window" icon when the monitor view is being displayed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that would be great and what I had been thinking of.
I will try to change the icon using Javascript.
It looks like something strange may be going on with sprockets. I first got an error message saying that I needed to add After I did that, I see this syntax error in SCSS:
|
This seems to work great now! Let's add the window closing icon to the monitor view (which I didn't see locally when I tested) and attempt to persist the window-drag dimensions between one page and another, the same way we do with zoom. On the second change, the use case here is that someone generally uses their second monitor to look at the image, so they have reduced the size of the image viewer portion of the transcription screen to something minimal, so that they have more room to type. If they save a page and navigate to the next one, we don't want the to have to re-resize their transcription window again. |
okay, let me figure them out. |
@benwbrum I pushed a new commit for showing close icon. Please have a look |
The close icon works really well. We still don't save the slider position, however:
|
Would you attach a screen record for the slider position issue? |
Strange, it works fine for me now. Merging. |
Closes #3358