-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2222 add undo/redo functionlity #4219
Conversation
…into 2222-undo-codemirror
…into 2222-undo-codemirror
@benwbrum I would actually put it next to the speech-to-text icon. I noticed that on most websites the undo and redo buttons tend to be on the leftmost side of the screen, and my eyes tend to look for those types of buttons on the left side of the screen too. |
Atef, can you try moving these icons next to the voice dictation icon, and also add tooltips to them? |
…into 2222-undo-codemirror
…omthepage into 2222-undo-codemirror
Ok... so these are actually "editor buttons", when you think about it. And when you have other editor buttons in place, it's obvious where they should go: Can we make these match the style of the add / date / del in the example, and put them to the left of any other buttons that are displayed in that spot right above the text field? These should always show up, unlike the table or any of the advanced mark-up buttons. |
Also, I'm not seeing tooltips. Based on this, I think we should move the voice dictation button to the same spot. Outside of scope for this PR, unless it's an easy change to make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI Decisions above.
Closes #2222