Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2222 add undo/redo functionlity #4219

Merged
merged 11 commits into from
Aug 19, 2024
Merged

2222 add undo/redo functionlity #4219

merged 11 commits into from
Aug 19, 2024

Conversation

atbah
Copy link
Collaborator

@atbah atbah commented Jul 11, 2024

Closes #2222

@atbah atbah requested a review from benwbrum July 11, 2024 07:00
@benwbrum
Copy link
Owner

@anabeabas Can you take a look at the undo/redo buttons in this screenshot and give us your opinion on their location/appearance? I'm not sure they should be on the same line as the Save/Preview buttons -- especially in top-to-bottom layout (in the second picture).

Screenshot from 2024-07-16 16-12-59

Screenshot from 2024-07-16 17-15-56

@anabasftp
Copy link
Collaborator

@benwbrum I would actually put it next to the speech-to-text icon. I noticed that on most websites the undo and redo buttons tend to be on the leftmost side of the screen, and my eyes tend to look for those types of buttons on the left side of the screen too.

@benwbrum
Copy link
Owner

Atef, can you try moving these icons next to the voice dictation icon, and also add tooltips to them?

@saracarl
Copy link
Collaborator

Ok... so these are actually "editor buttons", when you think about it. And when you have other editor buttons in place, it's obvious where they should go:

image

Can we make these match the style of the add / date / del in the example, and put them to the left of any other buttons that are displayed in that spot right above the text field? These should always show up, unlike the table or any of the advanced mark-up buttons.

@saracarl
Copy link
Collaborator

Also, I'm not seeing tooltips.

Based on this, I think we should move the voice dictation button to the same spot. Outside of scope for this PR, unless it's an easy change to make.

Copy link
Collaborator

@saracarl saracarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI Decisions above.

@benwbrum benwbrum merged commit 9be5649 into development Aug 19, 2024
3 checks passed
@benwbrum benwbrum deleted the 2222-undo-codemirror branch August 19, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced Editor Testing Feedback
4 participants