Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown table in code mirror #4240

Merged
merged 19 commits into from
Aug 21, 2024
Merged

Markdown table in code mirror #4240

merged 19 commits into from
Aug 21, 2024

Conversation

atbah
Copy link
Collaborator

@atbah atbah commented Jul 22, 2024

Closes #2753

@atbah atbah requested a review from benwbrum July 22, 2024 08:00
@saracarl
Copy link
Collaborator

So this works well, even with other markup buttons turned on:
image
However, this is an "advanced" sort of thing that would easily confuse transcribers, so I think we want to make it part of the editor buttons a project owner has to turn on. (For example here: http://localhost:3000/umdtranscription/david-c-driskell-papers/edit/tasks#edit-buttons)

Let's call it "Table" with the text "Inserts a markdown table of transcriber specified rows and columns"
Put it after superscript in the list.
Instead of trying to describe it after the checkbox, let's just say "Documentation" with a link to https://content.fromthepage.com/project-owner-documentation/table-encoding/

@benwbrum benwbrum merged commit 029217f into development Aug 21, 2024
1 check passed
@benwbrum benwbrum deleted the 2753-md-table-codemirror branch August 21, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeMirror button for inserting markdown tables
3 participants