Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4255 - Error making collection private #4257

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

WillNigel23
Copy link
Collaborator

#4255 (comment)

Added additional specs for validations. I suggest we also add tests for each part of model validations in the future.

@WillNigel23 WillNigel23 linked an issue Jul 31, 2024 that may be closed by this pull request
@WillNigel23 WillNigel23 requested a review from benwbrum July 31, 2024 23:11
@WillNigel23 WillNigel23 force-pushed the 4255-error-making-collection-private branch 2 times, most recently from d52e289 to 1b06228 Compare August 1, 2024 21:41
@WillNigel23 WillNigel23 force-pushed the 4255-error-making-collection-private branch from 1b06228 to 2ac7272 Compare August 1, 2024 22:26
Copy link
Collaborator

@saracarl saracarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I tried this with the original description that caused the problem -- the html with an ampersand -- and I thought we were handling the ampersand in some way. Looks like we're not?

image

So I'm confused and I feel like there's something missing here.

@WillNigel23
Copy link
Collaborator Author

Seems like a bug on my end. Will check it out monday

@WillNigel23 WillNigel23 requested a review from saracarl August 5, 2024 20:24
@WillNigel23
Copy link
Collaborator Author

@saracarl I can't reproduce this error using the provided link you sent to me. Are you certain your branch is up to date?

Also might be worth restarting your local dev server

@saracarl saracarl merged commit b4bb0ed into development Aug 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

422 error making collection private
2 participants