Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4319: only gsub if there is text #4321

Merged
merged 1 commit into from
Sep 9, 2024
Merged

#4319: only gsub if there is text #4321

merged 1 commit into from
Sep 9, 2024

Conversation

benwbrum
Copy link
Owner

@benwbrum benwbrum commented Sep 9, 2024

Closes #4319

(It turns out that this was caused by calling gsub on elements that had nil .text)

WillNigel23
WillNigel23 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@WillNigel23 WillNigel23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        e.text = e.text&.gsub("'", "`")

We can do this instead

@saracarl saracarl merged commit 7699a69 into development Sep 9, 2024
3 checks passed
@benwbrum benwbrum deleted the 4319-fix-500-on-empty-tag branch December 13, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillNigel23 WillNigel23 WillNigel23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gsub 500 on page display
3 participants
@benwbrum @WillNigel23 @saracarl