4325 - Carrierwave deprecated 'extension_white_list' #4326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillNigel23
commented
Sep 10, 2024
| @@ -0,0 +1,5 @@ | |||
| FactoryBot.define do | |||
| factory :document_upload do | |||
| file { Rack::Test::UploadedFile.new(File.open(File.join(Rails.root, 'test_data/uploads/test.pdf'))) } | |||
There was a problem hiding this comment.
This will allow us to create document_upload factory easier
WillNigel23
commented
Sep 10, 2024
| expect(subject).not_to be_valid | ||
| expect(subject.errors.messages[:file]).to include( | ||
| "can't be blank", | ||
| 'You are not allowed to upload "txt" files, allowed types: zip, pdf' |
There was a problem hiding this comment.
This spec should catch (if by any chance carrierwave change their methods again) and validates that the file whitelisting works
WillNigel23
force-pushed
the
4325-carrierwave-allowlist
branch
from
bcda596 to
d08ff3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.