Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update newrelic and rubysaml gems #4339

Merged
merged 2 commits into from
Sep 19, 2024
Merged

update newrelic and rubysaml gems #4339

merged 2 commits into from
Sep 19, 2024

Conversation

saracarl
Copy link
Collaborator

@saracarl saracarl commented Sep 18, 2024

@saracarl
Copy link
Collaborator Author

Test failures are all in xml_source_processor:

rspec ./spec/models/xml_source_processor_spec.rb:39 # XmlSourceProcessor#wiki_to_xml subject linking not disabled (default) builds the xml document
rspec ./spec/models/xml_source_processor_spec.rb:48 # XmlSourceProcessor#wiki_to_xml subject linking disabled builds the xml document
rspec ./spec/models/xml_source_processor_spec.rb:63 # XmlSourceProcessor#valid_xml_from_source builds the xml document

@@ -493,7 +493,7 @@ GEM
responders (3.1.1)
actionpack (>= 5.2)
railties (>= 5.2)
rexml (3.2.6)
rexml (3.3.7)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this gem change be causing xml_source_processing errors?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have encountered this before, it seems the change in rexml gem removed the extra '\n' here.

I'm not entirely sure if this is indeed due to some gem updates they are working on at their end, but if we check most of the difference are extra whitespaces and '\n', I don't think this is fatal for our codebase. @saracarl

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading image.png…

Copy link
Collaborator

@WillNigel23 WillNigel23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chomp ᑈ

@WillNigel23 WillNigel23 merged commit 20d445c into development Sep 19, 2024
3 checks passed
@saracarl saracarl deleted the gem-updates branch September 19, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants