-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update newrelic and rubysaml gems #4339
Conversation
Test failures are all in xml_source_processor:
|
@@ -493,7 +493,7 @@ GEM | |||
responders (3.1.1) | |||
actionpack (>= 5.2) | |||
railties (>= 5.2) | |||
rexml (3.2.6) | |||
rexml (3.3.7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this gem change be causing xml_source_processing errors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have encountered this before, it seems the change in rexml gem removed the extra '\n' here.
I'm not entirely sure if this is indeed due to some gem updates they are working on at their end, but if we check most of the difference are extra whitespaces and '\n', I don't think this is fatal for our codebase. @saracarl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chomp ᑈ
addresses https://nvd.nist.gov/vuln/detail/CVE-2024-45409