Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4374 syntax highlighting for unbalanced tags #4391

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

atbah
Copy link
Collaborator

@atbah atbah commented Oct 24, 2024

Closes #4374

@benwbrum FYI: The codemirror editor displays this errors for the unbalanced tags.
image

Copy link
Collaborator

@saracarl saracarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine with TEI tags, but I'm worried that volunteers may insert (validly) HTML tags and those don't seem to be working as well:

image
specifically

  • the close br -- which I don't even know if that's valid html, but our parser wanted it closed
  • the valid h1 which we are throwing a warning on.

@saracarl saracarl assigned atbah and unassigned saracarl Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax highlighting for unbalanced XML/HTML tags
2 participants