Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #9, prettier settings #18

Merged
merged 3 commits into from
Jul 26, 2015
Merged

Conversation

LudwikJaniuk
Copy link

Rearranged the GUI in the settings window to make it look better and waste less space. This was accomplished using these methods:

  1. Let the labels and input boxes be in separate columns beside each other, instead of the same column as it was before.
  2. Took the two wider setting elements ("Edit comma" and "Hold down time") and removed them from the main button settings. That way every other button setting label did not have to be extended to align well, and we saved a lot of space.
  3. Special care was taken for the "misc" elements at the end (check boxes, save button, version label...), so that they could fill out the horizontal space left by the two columns above. This was accomplished using AHK "Sections", which are further explained in the comments.

The one thing I think still is missing is having the "misc options" (or at least the save button and/or the version text) be aligned to the bottom right corner, but I was not able to accomplish that.

LudwikJaniuk added 3 commits July 26, 2015 10:01
As proposed in #9, made the settings page a little more readable.  It's
can still be made better, but this is a start. Also, removed the fixed
window dimentsions on line (now) 343. Why was that there in the first
place? AHK can figure out the dimensions itself, so this will be a more
flexible approach.
Achieved this by moving the two "wide" options (time holding and the
comma) to the third column, therefore not wasting whitespace on all the
button options.
Added some columns nesting to the "misc options" at the end of the
settings, to make it look much better. I might work more on this later,
but for now, I'm pretty contntent with the look of the settings page.
benwoodman added a commit that referenced this pull request Jul 26, 2015
@benwoodman benwoodman merged commit 72a5c6a into benwoodman:master Jul 26, 2015
@benwoodman
Copy link
Owner

Thank you so much! It looks so much better

@LudwikJaniuk
Copy link
Author

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants