Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added theme clock #83

Merged
merged 2 commits into from
Dec 7, 2020
Merged

added theme clock #83

merged 2 commits into from
Dec 7, 2020

Conversation

krissh-the-dev
Copy link
Member

closes #53

image

@krissh-the-dev krissh-the-dev added the feature New feature request label Dec 7, 2020
@krissh-the-dev krissh-the-dev added this to the 7 days 50 projects milestone Dec 7, 2020
@krissh-the-dev krissh-the-dev self-assigned this Dec 7, 2020
sank2000
sank2000 requested changes Dec 7, 2020
View reviewed changes
Copy link
Member

@sank2000 sank2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

animation should be continue ..(after 60 sec the needle animation is reseted)

i think you can fix that with animation direction

@krissh-the-dev
Copy link
Member Author

animation should be continue ..(after 60 sec the needle animation is reseted)

i think you can fix that with animation direction

I don't think its possible at all.

@krissh-the-dev
Copy link
Member Author

Refer the original also. Ours is far better XD

@krissh-the-dev krissh-the-dev mentioned this pull request Dec 7, 2020
Open
sank2000
sank2000 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@sank2000 sank2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@PranavGPR PranavGPR merged commit 23a69d2 into master Dec 7, 2020
@PranavGPR PranavGPR deleted the theme-clock branch December 7, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PranavGPR PranavGPR PranavGPR approved these changes

@sank2000 sank2000 sank2000 approved these changes

@Lakshmi2k1 Lakshmi2k1 Awaiting requested review from Lakshmi2k1

Assignees

@krissh-the-dev krissh-the-dev

Labels
feature New feature request
Projects
None yet
Milestone
7 days 50 projects
Development

Successfully merging this pull request may close these issues.

Add Theme Clock (Day 19)
3 participants
@krissh-the-dev @sank2000 @PranavGPR