Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postcss config: console.log output should be put in comment #12

Merged
merged 1 commit into from
May 30, 2023

Conversation

imfing
Copy link
Contributor

@imfing imfing commented May 23, 2023

image

the console.log output has been written to the output CSS file, and it should be put into a comment block otherwise it would invalidate the first CSS rule.

@imfing imfing changed the title Fix postcss config console.log output should be put in comment Fix postcss config: console.log output should be put in comment May 23, 2023
@JugglerX
Copy link

This causes a big problem.

*,::before,::after{box-sizing:border-box;border-width:0;border-style:solid;border-color:#e5e7eb}

The first css line is responsible for setting box-sizing: border-box on the entire framework. Without it all the margins, paddings and widths will be incorrect causing all kinds of subtle and not so subtle issues to the sites design.

@bep
Copy link
Owner

bep commented May 30, 2023

A little surprised to see PostCSS/tailwind include log output in the final output. That sounds like a bug.

@bep bep merged commit 000c8b1 into bep:master May 30, 2023
4 checks passed
@imfing imfing deleted the fix-postcss-config branch May 30, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants