Allow empty params.mainSections

Updates gohugoio#10953
bep · May 18, 2023 · 6d616c2 · 6d616c2
1 parent 612e8f2
commit 6d616c2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/config/allconfig/allconfig.go b/config/allconfig/allconfig.go
@@ -367,7 +367,7 @@ type ConfigCompiled struct {
 func (c *ConfigCompiled) SetMainSectionsIfNotSet(sections []string) {
 	c.mu.Lock()
 	defer c.mu.Unlock()
-	if len(c.MainSections) > 0 {
+	if c.MainSections != nil {
 		return
 	}
 	c.MainSections = sections

diff --git a/config/allconfig/alldecoders.go b/config/allconfig/alldecoders.go
@@ -177,6 +177,9 @@ var allDecoderSetups = map[string]decodeWeight{
 			// Before Hugo 0.112.0 this was configured via site Params.
 			if mainSections, found := p.c.Params["mainsections"]; found {
 				p.c.MainSections = types.ToStringSlicePreserveString(mainSections)
+				if p.c.MainSections == nil {
+					p.c.MainSections = []string{}
+				}
 			}
 
 			return nil

diff --git a/hugolib/config_test.go b/hugolib/config_test.go
@@ -872,16 +872,17 @@ Param: svParamValue
 
 }
 
-func TestReproCommentsIn10953(t *testing.T) {
+func TestConfigEmptyMainSections(t *testing.T) {
 	t.Parallel()
 
 	files := `
--- hugo.toml --
-baseURL = "https://example.com"
-disableKinds = ["taxonomy", "term", "RSS", "sitemap", "robotsTXT"]
+-- hugo.yml --
+params:
+  mainSections:
+-- content/mysection/_index.md --
+-- content/mysection/mycontent.md --
 -- layouts/index.html --
-{{ range first 1 .Params.images }}{{ end }}
-
+mainSections: {{ site.Params.mainSections }}
 
 `
 	b := NewIntegrationTestBuilder(
@@ -892,7 +893,7 @@ disableKinds = ["taxonomy", "term", "RSS", "sitemap", "robotsTXT"]
 	).Build()
 
 	b.AssertFileContent("public/index.html", `
-
+mainSections: []
 `)
 
 }