Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance VPN Service Notifications with Dynamic State and Mode Information #387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhance VPN Service Notifications with Dynamic State and Mode Information #387

wants to merge 1 commit into from

Conversation

Epic-R-R
Copy link
Contributor

@Epic-R-R Epic-R-R commented Aug 17, 2024 •
edited
Loading

This pull request improves the user experience by enhancing the VPN service notifications with dynamic state and mode information.

Key changes:

  1. Updated the createNotification method to display the current connection state in the notification title.
  2. The getNotificationTitle method was added to generate appropriate titles based on the connection state (Connecting, Connected, Disconnected).
  3. Introduced the getNotificationContent method to provide detailed information about the current VPN mode (Proxy/VPN) and settings (Psiphon, Warp, port).
  4. Modified setLastKnownState method to update the notification whenever the connection state changes.

These changes will provide users with more immediate and detailed information about the VPN service status directly from the notification, improving the overall usability and transparency of the application.

Testing:

  • Tested the notification updates across different connection states and modes.
  • Verified that the notification content accurately reflects the current settings and mode.

Please review and let me know if any further adjustments are needed.

@Epic-R-R
Enhance VPN service notification with dynamic state and mode information
3497815 
- Update createNotification method to show connection state in title
- Add getNotificationTitle and getNotificationContent methods
- Modify setLastKnownState to update notification on state change
- Improve readability and user experience with more detailed notifications
@Epic-R-R Epic-R-R closed this Aug 17, 2024
@Epic-R-R Epic-R-R reopened this Aug 17, 2024
@Epic-R-R Epic-R-R changed the title Enhance VPN service notification with dynamic state and mode information Enhance VPN Service Notifications with Dynamic State and Mode Information Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Epic-R-R