fix(blob): potential inclusion proof has bug (#1832)

berachain · Jul 31, 2024 · f6f3f66 · f6f3f66
1 parent 90772c9
commit f6f3f66
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/mod/consensus-types/pkg/types/body.go b/mod/consensus-types/pkg/types/body.go
@@ -298,6 +298,8 @@ func (b *BeaconBlockBody) GetTopLevelRoots() []common.Root {
 		b.GetGraffiti().HashTreeRoot(),
 		Deposits(b.GetDeposits()).HashTreeRoot(),
 		b.GetExecutionPayload().HashTreeRoot(),
+		// I think this is a bug.
+		common.Root{},
 	}
 }
 

diff --git a/mod/da/pkg/blob/factory.go b/mod/da/pkg/blob/factory.go
@@ -137,9 +137,8 @@ func (f *SidecarFactory[BeaconBlockT, BeaconBlockBodyT]) BuildBlockBodyProof(
 ) ([]common.Root, error) {
 	startTime := time.Now()
 	defer f.metrics.measureBuildBlockBodyProofDuration(startTime)
-	membersRoots := body.GetTopLevelRoots()
 	tree, err := merkle.NewTreeWithMaxLeaves[common.Root](
-		membersRoots,
+		body.GetTopLevelRoots(),
 		body.Length()-1,
 	)
 	if err != nil {