chore(node-builder): depinject db pruners and manager #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archbear
approved these changes
Jun 9, 2024
|
|
||
| // AvailabilityPrunerInput is the input for the ProviderAvailabilityPruner | ||
| // function for the depinject framework. | ||
| type AvailabilityPrunerInput struct { |
There was a problem hiding this comment.
nit: AvailabilityStorePruner
| // Pruner is a struct that holds the prunable interface and a notifier channel. | ||
| type Pruner[ | ||
| // DBPruner is a struct that holds the prunable interface and a notifier channel. | ||
| type DBPruner[ |
There was a problem hiding this comment.
can make this a private type with a public constructor
There was a problem hiding this comment.
i think we still need to reference the public type though to make the injection into dbmanager work
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
==========================================
- Coverage 21.53% 21.53% -0.01%
==========================================
Files 236 238 +2
Lines 11238 11239 +1
Branches 18 18
==========================================
Hits 2420 2420
- Misses 8656 8657 +1
Partials 162 162
|
Signed-off-by: ocnc2 <169075746+ocnc2@users.noreply.github.com>
|
@ocnc2 imma merge, but address archs feedback after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i love generics