tests for other scenarios

[nidhi-singh02]

Summary by CodeRabbit

• Tests

  • Introduced new tests for BeaconBlock to check for nil instances.
  • Added tests for building payload requests and validating versioned and block hashes in the engine-primitives package.

• Chores

  • Updated subproject dependencies for forge-std and solady libraries.

[coderabbitai]

Warning

Review failed

The pull request is closed.

Walkthrough

The changes introduce updates to commit hashes for the forge-std and solady subprojects, and extend testing functions in consensus-types and engine-primitives. New test functions and enhancements to existing ones improve validation and functionality checks for the BeaconBlock and payload requests.

Changes

Files	Change Summary
contracts/lib/forge-std	Update subproject commit hash from 6e05729b76f1ae0d437e74951aef1ca987788ab3 to 52715a217dc51d0de15877878ab8213f6cbbbab5
contracts/lib/solady	Update subproject commit hash within the contracts/lib/solady directory
mod/…/pkg/types/block_test.go	Added TestBeaconBlock_IsNil function and IsNil method to BeaconBlock
mod/…/pkg/engine-primitives/requests_test.go	Added new test functions, adjusted existing ones, and updated logic for payload request construction and hash validation, such as TestBuildGetPayloadRequest etc.

Sequence Diagram(s)

Silently skipped.

Poem

Amid the lines of code so bright,

New tests take flight in the night.

Payloads built, hashes align,

Subproject's commit, a subtle sign.

Beacon blocks now stay in sight,

For every change, the future's light.

🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between eebf5e8 and 19ffa45.

Files selected for processing (4)

• contracts/lib/forge-std (1 hunks)
• contracts/lib/solady (1 hunks)
• mod/consensus-types/pkg/types/block_test.go (1 hunks)
• mod/engine-primitives/pkg/engine-primitives/requests_test.go (2 hunks)

Additional comments not posted (4)

contracts/lib/forge-std (1)

1-1: Update to forge-std subproject commit hash approved.

contracts/lib/solady (1)

1-1: Update to solady subproject commit hash approved.

mod/engine-primitives/pkg/engine-primitives/requests_test.go (2)

149-158: The new test function TestBuildGetPayloadRequest correctly sets up and asserts the properties of a payload request. Well done on maintaining thorough checks.

---

160-160: Renaming and refactoring of test functions to more accurately describe their purpose is a good practice. Ensure that all related documentation and any dependent scripts or tools are updated to reflect the new test function names.

Also applies to: 177-191

Verification successful

---

The search results indicate that the old test function name TestHasValidVersionedAndBlockHashesError is no longer present, and the new name TestHasValidVersionedAndBlockHashesPayloadError is correctly used in the test file. There are no occurrences of the old name in the broader set of file types checked.

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify all documentation and scripts for updated test names.

# Test: Search for old test function names in documentation and scripts. Expect: No occurrences.
rg --type md --type sh 'TestHasValidVersionedAndBlockHashesError|TestHasValidVersionedAndBlockHashesPayloadError'

Length of output: 115

---

---

Script:

#!/bin/bash
# Description: Verify all documentation and scripts for updated test names.

# Test: Search for old test function names in a broader set of file types. Expect: No occurrences.
rg --type md --type sh --type go --type yaml --type json 'TestHasValidVersionedAndBlockHashesError|TestHasValidVersionedAndBlockHashesPayloadError'

Length of output: 279