chore(node-core): remove chain service from middleware + cleanup #1842
Conversation
WalkthroughThe recent changes involve updating the Mockery tool version from v2.43.2 to v2.44.1 across multiple mock files. Furthermore, significant modifications were made to structures and functions within core components such as Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant API
participant Service
participant Logger
User->>API: Request data
API->>Logger: Log request
API->>Service: Fetch data
Service-->>API: Return data
API-->>User: Respond with data
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (37)
- mod/engine-primitives/pkg/engine-primitives/mocks/blobs_bundle.mock.go (1 hunks)
- mod/engine-primitives/pkg/engine-primitives/mocks/built_execution_payload_env.mock.go (1 hunks)
- mod/engine-primitives/pkg/engine-primitives/mocks/payload_attributer.mock.go (1 hunks)
- mod/node-api/backend/mocks/availability_store.mock.go (1 hunks)
- mod/node-api/backend/mocks/beacon_block_header.mock.go (1 hunks)
- mod/node-api/backend/mocks/beacon_state.mock.go (1 hunks)
- mod/node-api/backend/mocks/block_store.mock.go (1 hunks)
- mod/node-api/backend/mocks/deposit_store.mock.go (1 hunks)
- mod/node-api/backend/mocks/node.mock.go (1 hunks)
- mod/node-api/backend/mocks/state_processor.mock.go (1 hunks)
- mod/node-api/backend/mocks/storage_backend.mock.go (1 hunks)
- mod/node-api/backend/mocks/validator.mock.go (1 hunks)
- mod/node-api/backend/mocks/withdrawal.mock.go (1 hunks)
- mod/node-api/backend/mocks/withdrawal_credentials.mock.go (1 hunks)
- mod/node-core/pkg/components/api.go (3 hunks)
- mod/node-core/pkg/components/api_handlers.go (1 hunks)
- mod/node-core/pkg/components/attributes_factory.go (1 hunks)
- mod/node-core/pkg/components/backend.go (1 hunks)
- mod/node-core/pkg/components/block_store.go (1 hunks)
- mod/node-core/pkg/components/block_store_service.go (1 hunks)
- mod/node-core/pkg/components/brokers.go (2 hunks)
- mod/node-core/pkg/components/chain_service.go (1 hunks)
- mod/node-core/pkg/components/db_manager.go (1 hunks)
- mod/node-core/pkg/components/defaults.go (2 hunks)
- mod/node-core/pkg/components/middleware.go (2 hunks)
- mod/node-core/pkg/components/reporting_service.go (1 hunks)
- mod/node-core/pkg/components/service_registry.go (3 hunks)
- mod/node-core/pkg/components/types.go (2 hunks)
- mod/primitives/pkg/crypto/mocks/bls_signer.mock.go (1 hunks)
- mod/runtime/pkg/middleware/middleware.go (3 hunks)
- mod/runtime/pkg/service/mocks/basic.mock.go (1 hunks)
- mod/runtime/pkg/service/mocks/registry_option.mock.go (1 hunks)
- mod/storage/pkg/interfaces/mocks/db.mock.go (1 hunks)
- mod/storage/pkg/pruner/mocks/beacon_block.mock.go (1 hunks)
- mod/storage/pkg/pruner/mocks/block_event.mock.go (1 hunks)
- mod/storage/pkg/pruner/mocks/prunable.mock.go (1 hunks)
- mod/storage/pkg/pruner/mocks/pruner.mock.go (1 hunks)
Additional comments not posted (51)
mod/node-core/pkg/components/db_manager.go (1)
34-34: LGTM! Field reordering is fine.The reordering of the
DepositPrunerfield does not affect functionality and may improve readability.mod/node-core/pkg/components/block_store_service.go (1)
36-37: LGTM! Field reordering is fine.The reordering of the
ConfigandLoggerfields does not affect functionality and may improve readability.mod/node-core/pkg/components/reporting_service.go (3)
1-19: LGTM! Standard licensing information.The file header contains standard licensing information and does not require changes.
32-36: LGTM! Well-defined struct.The
ReportingServiceInputstruct is well-defined and follows standard practices.
38-43: LGTM! Well-defined function.The
ProvideReportingServicefunction follows standard practices and correctly initializes the reporting service.mod/node-core/pkg/components/attributes_factory.go (4)
24-24: Import approved.The addition of the
depinjectimport is appropriate for the updated function signature that uses dependency injection.
31-38: New struct approved.The
AttributesFactoryInputstruct consolidates related parameters, enhancing readability and maintainability.
42-43: Function signature change approved.The
ProvideAttributesFactoryfunction now takes a single parameter of typeAttributesFactoryInput, simplifying the function signature and aligning with best practices in dependency injection.
50-53: Internal logic change approved.The internal logic of
ProvideAttributesFactoryhas been updated to reference the fields of theAttributesFactoryInputstruct, clarifying the source of each argument and reducing cognitive load.mod/storage/pkg/pruner/mocks/beacon_block.mock.go (1)
1-1: Version number update approved.The version number in the comment header has been updated to
v2.44.1, indicating the use of a newer version of the mock generation tool.mod/storage/pkg/pruner/mocks/prunable.mock.go (1)
1-1: Version number update approved.The version number in the comment header has been updated to
v2.44.1, indicating the use of a newer version of the mock generation tool.mod/node-core/pkg/components/backend.go (2)
33-33: LGTM! The reordering of fields improves logical grouping.The
BlockStorefield has been moved to follow theAvailabilityStorefield, which enhances the readability and logical grouping of the struct.
Line range hint
24-29:
LGTM! The inclusion ofBlockStorein thedepinject.Insection is consistent with the struct changes.The
BlockStorefield is now included in thedepinject.Insection, which aligns with the updated struct definition.mod/node-core/pkg/components/defaults.go (1)
Line range hint
24-62:
LGTM! The restructuring enhances modularity and maintainability.The function now initializes a
componentsvariable and populates it with several component providers dynamically, which improves the modularity and maintainability of the code.mod/runtime/pkg/service/mocks/registry_option.mock.go (1)
1-1: LGTM! The version update of the mock generation tool is consistent.The version of the mock generation tool has been updated from v2.43.2 to v2.44.1, which may suggest improvements or bug fixes in the tool itself.
mod/node-core/pkg/components/middleware.go (2)
Line range hint
14-23:
LGTM! Verify the usage ofChainServicein the codebase.The removal of
ChainServicefromABCIMiddlewareInputis a good step towards reducing dependencies and improving modularity.Ensure that any previous usage of
ChainServicein the codebase has been updated or refactored accordingly.Verification successful
LGTM! The removal of
ChainServicefromABCIMiddlewareInputhas been properly handled.The
ABCIMiddlewareInputstruct is only used withinmod/node-core/pkg/components/middleware.go, and there are no other references to it in the codebase. The change does not impact other parts of the code.
mod/node-core/pkg/components/middleware.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `ChainService` in the codebase. # Test: Search for the usage of `ChainService`. Expect: No occurrences of `ChainService` in the context of `ABCIMiddlewareInput`. rg --type go -A 5 'ChainService'Length of output: 3139
Script:
#!/bin/bash # Description: Verify the usage of `ABCIMiddlewareInput` in the codebase. # Test: Search for the usage of `ABCIMiddlewareInput`. Expect: Ensure that the removal of `ChainService` has been properly handled. rg --type go -A 5 'ABCIMiddlewareInput'Length of output: 1035
Line range hint
26-43:
LGTM! Verify the function calls toProvideABCIMiddleware.The removal of
ChainServicefrom theProvideABCIMiddlewarefunction signature is a good step towards reducing dependencies and improving modularity.Ensure that all calls to
ProvideABCIMiddlewarehave been updated to match the new signature.mod/node-core/pkg/components/brokers.go (3)
69-79: LGTM!The addition of
DefaultBrokerProvidersimproves the organization and accessibility of broker provider instances.
27-30: LGTM! Verify the function calls toProvideBlobBroker.The renaming of
ProvideBlobFeedtoProvideBlobBrokerenhances clarity by aligning the function name with its purpose.Ensure that all calls to
ProvideBlobFeedhave been updated toProvideBlobBroker.Verification successful
Renaming verified successfully!
All references to
ProvideBlobFeedhave been updated toProvideBlobBroker. No occurrences of the old function name were found in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the function calls to `ProvideBlobBroker`. # Test: Search for the function calls to `ProvideBlobBroker`. Expect: Only occurrences of the new function name. rg --type go -A 5 'ProvideBlobBroker'Length of output: 875
Script:
#!/bin/bash # Description: Verify that there are no remaining calls to the old function name `ProvideBlobFeed`. # Test: Search for the function calls to `ProvideBlobFeed`. Expect: No occurrences of the old function name. rg --type go -A 5 'ProvideBlobFeed'Length of output: 35
34-37: LGTM! Verify the function calls toProvideBlockBroker.The renaming of
ProvideBlockFeedtoProvideBlockBrokerenhances clarity by aligning the function name with its purpose.Ensure that all calls to
ProvideBlockFeedhave been updated toProvideBlockBroker.Verification successful
Renaming successfully verified!
All calls to
ProvideBlockFeedhave been updated toProvideBlockBroker, and there are no remaining references to the old function name in the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the function calls to `ProvideBlockBroker`. # Test: Search for the function calls to `ProvideBlockBroker`. Expect: Only occurrences of the new function name. rg --type go -A 5 'ProvideBlockBroker'Length of output: 855
Script:
#!/bin/bash # Description: Verify if any calls to the old function name `ProvideBlockFeed` still exist. # Test: Search for the function calls to `ProvideBlockFeed`. Expect: No occurrences of the old function name. rg --type go 'ProvideBlockFeed'Length of output: 31
mod/node-api/backend/mocks/withdrawal.mock.go (1)
1-1: LGTM!The update of the mockery tool version in the comment header accurately reflects the version used to generate the mock files.
mod/node-api/backend/mocks/node.mock.go (1)
1-1: Version update in comment header.The version number in the comment header has been updated from
mockery v2.43.2tomockery v2.44.1. This change indicates the file has been regenerated using the newer version of the mockery tool.mod/node-api/backend/mocks/withdrawal_credentials.mock.go (1)
1-1: Version update in comment header.The version number in the comment header has been updated from
mockery v2.43.2tomockery v2.44.1. This change indicates the file has been regenerated using the newer version of the mockery tool.mod/node-core/pkg/components/service_registry.go (2)
38-44: New field added and reordering of fields inServiceRegistryInput.The
ReportingServicefield has been added to theServiceRegistryInputstructure, enhancing the service registry's capabilities. TheDBManagerfield has been reordered, which may improve readability.
65-65: Simplified service provision logic inProvideServiceRegistry.The
ProvideServiceRegistryfunction now directly utilizes theReportingServicefield from theServiceRegistryInput, simplifying the service provision logic and potentially improving maintainability and reducing complexity.mod/runtime/pkg/service/mocks/basic.mock.go (1)
1-1: LGTM! Verify the usage of the new mockery version.The version update to
mockery v2.44.1is approved.However, ensure that the new version does not introduce any issues in the generated mocks.
Verification successful
The new mockery version
v2.44.1is consistently used across all generated mocks. No other versions were found, indicating a uniform update.
- All mock files are generated using
mockery v2.44.1.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the new mockery version. # Test: Check for the new version in the generated mocks. Expect: Only occurrences of the new version. rg --type go -A 1 $'Code generated by mockery v2.44.1'Length of output: 3582
Script:
#!/bin/bash # Description: Verify if there are any other versions of mockery used in the codebase. # Test: Check for any other versions of mockery in the generated mocks. Expect: No occurrences of other versions. rg --type go -A 1 $'Code generated by mockery v'Length of output: 3576
mod/node-core/pkg/components/chain_service.go (1)
37-37: LGTM!The addition of a blank line in the
ChainServiceInputstruct definition for improved readability is approved.mod/node-core/pkg/components/block_store.go (1)
65-65: LGTM! Verify the usage of theBlockPrunerInputstruct.The repositioning of the
Configfield within theBlockPrunerInputstruct for logical grouping is approved.However, ensure that the change does not affect the initialization or usage of the struct.
Verification successful
No issues found with the
BlockPrunerInputstruct initialization or usage.The search did not reveal any explicit initializations of the
BlockPrunerInputstruct that could be affected by the field order change. It is likely that the struct is being used in a context where its fields are automatically injected or assigned, which should not be impacted by the reordering.
- The
BlockPrunerInputstruct is defined and used as expected.- No explicit initializations were found that could be affected by the field order change.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the `BlockPrunerInput` struct. # Test: Search for the `BlockPrunerInput` struct usage. Expect: No issues due to the field order change. rg --type go -A 5 $'BlockPrunerInput'Length of output: 982
Script:
#!/bin/bash # Description: Verify the initialization of the `BlockPrunerInput` struct. # Test: Search for the initialization of the `BlockPrunerInput` struct. Expect: No issues due to the field order change. rg --type go 'BlockPrunerInput{'Length of output: 132
Script:
#!/bin/bash # Description: Verify the initialization of the `BlockPrunerInput` struct. # Test: Search for the initialization of the `BlockPrunerInput` struct. Expect: No issues due to the field order change. rg --type go 'BlockPrunerInput\{'Length of output: 35
Script:
#!/bin/bash # Description: Verify all references to the `BlockPrunerInput` struct. # Test: Search for all references to `BlockPrunerInput` in the codebase. Expect: No issues due to the field order change. rg --type go 'BlockPrunerInput'Length of output: 271
mod/node-core/pkg/components/api.go (3)
47-47: Approved: Addition ofStorageBackendfield.The addition of the
StorageBackendfield toNodeAPIBackendInputis a positive change, improving the struct's functionality and integration with storage systems.
86-86: Approved: Reordering of fields inNodeAPIServerInput.The reordering of the
Loggerfield inNodeAPIServerInputenhances the clarity and maintainability of the struct.
103-109: Approved: Addition ofDefaultNodeAPIComponentsfunction.The new
DefaultNodeAPIComponentsfunction enhances modularity and reusability, making it easier to initialize and configure Node API components.mod/storage/pkg/pruner/mocks/pruner.mock.go (1)
1-1: Acknowledged: Update of mockery tool version.The version update to
mockery v2.44.1is noted. This change does not affect the functionality or logic of the code.mod/node-api/backend/mocks/state_processor.mock.go (1)
1-1: Acknowledged: Update of mockery tool version.The version update to
mockery v2.44.1is noted. This change does not affect the functionality or logic of the code.mod/node-core/pkg/components/api_handlers.go (1)
94-105: LGTM! The new function enhances modularity and usability.The
DefaultNodeAPIHandlersfunction correctly aggregates and returns a slice of handler functions, improving the structure of the API.mod/storage/pkg/pruner/mocks/block_event.mock.go (1)
1-1: Acknowledgement: Version update in the code generation tool.The version update from
v2.43.2tov2.44.1in the code generation toolmockeryis noted. The functionality and logic of the code remain unchanged.mod/engine-primitives/pkg/engine-primitives/mocks/blobs_bundle.mock.go (1)
1-1: Acknowledgement: Version update in the code generation tool.The version update from
v2.43.2tov2.44.1in the code generation toolmockeryis noted. The functionality and logic of the code remain unchanged.mod/engine-primitives/pkg/engine-primitives/mocks/payload_attributer.mock.go (1)
1-1: Version update for mockery tool.The mockery tool version has been updated from v2.43.2 to v2.44.1. Ensure that the new version does not introduce any inconsistencies or issues.
mod/node-api/backend/mocks/block_store.mock.go (1)
1-1: Version update for mockery tool.The mockery tool version has been updated from v2.43.2 to v2.44.1. Ensure that the new version does not introduce any inconsistencies or issues.
mod/primitives/pkg/crypto/mocks/bls_signer.mock.go (1)
1-1: Version update for mockery tool.The mockery tool version has been updated from v2.43.2 to v2.44.1. Ensure that the new version does not introduce any inconsistencies or issues.
mod/node-api/backend/mocks/availability_store.mock.go (1)
1-1: Metadata update: Mockery version incremented.The version of the mockery tool used for code generation has been updated from v2.43.2 to v2.44.1. This change is purely metadata and does not affect the functionality or structure of the code.
mod/storage/pkg/interfaces/mocks/db.mock.go (1)
1-1: Metadata update: Mockery version incremented.The version of the mockery tool used for code generation has been updated from v2.43.2 to v2.44.1. This change is purely metadata and does not affect the functionality or structure of the code.
mod/node-api/backend/mocks/deposit_store.mock.go (1)
1-1: Metadata update: Mockery version incremented.The version of the mockery tool used for code generation has been updated from v2.43.2 to v2.44.1. This change is purely metadata and does not affect the functionality or structure of the code.
mod/runtime/pkg/middleware/middleware.go (2)
129-129: LGTM! But verify the impact of removingchainServiceparameter.The removal of the
chainServiceparameter from theNewABCIMiddlewareconstructor function streamlines the instantiation process.However, ensure that all parts of the codebase that call this constructor are updated accordingly.
Verification successful
Verify the impact of removing
chainServiceparameter.The
NewABCIMiddlewarefunction is used inmod/node-core/pkg/components/middleware.go. Ensure that this usage conforms to the new signature without thechainServiceparameter.
LGTM! But verify the impact of removing
chainServiceparameter.The removal of the
chainServiceparameter from theNewABCIMiddlewareconstructor function streamlines the instantiation process. The usage inmod/node-core/pkg/components/middleware.goconfirms that the new signature is correctly used without thechainServiceparameter.
mod/node-core/pkg/components/middleware.go: Verified correct usage ofNewABCIMiddlewarewithoutchainService.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of removing `chainService` parameter from `NewABCIMiddleware`. # Test: Search for the usage of `NewABCIMiddleware` in the codebase. Expect: Only occurrences of the new signature. rg --type go -A 5 $'NewABCIMiddleware'Length of output: 997
Script:
#!/bin/bash # Description: Verify the complete function call of `NewABCIMiddleware` in `mod/node-core/pkg/components/middleware.go`. # Print the lines around the function call to see the full context. rg --type go -A 10 -B 10 $'NewABCIMiddleware' mod/node-core/pkg/components/middleware.goLength of output: 628
Line range hint
41-41:
LGTM! But verify the impact of removingchainService.The removal of the
chainServicefield simplifies theABCIMiddlewarestruct, improving maintainability and modularity.However, ensure that all parts of the codebase that relied on this field are updated accordingly.
Verification successful
LGTM! But verify the impact of removing
chainService.The removal of the
chainServicefield simplifies theABCIMiddlewarestruct, improving maintainability and modularity.However, ensure that all parts of the codebase that relied on this field are updated accordingly.
- There are no direct references to
chainServicewithin the context ofABCIMiddleware.- The
chainServicefield is defined but not actively used elsewhere in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of removing `chainService` from `ABCIMiddleware`. # Test: Search for the usage of `chainService` in the codebase. Expect: No occurrences. rg --type go -A 5 $'chainService'Length of output: 575
Script:
#!/bin/bash # Description: Verify the impact of removing `chainService` from `ABCIMiddleware` by searching for references to `BlockchainService` in the codebase. # Test: Search for the usage of `BlockchainService` in the codebase. Expect: Occurrences showing how it's used. rg --type go -A 5 $'BlockchainService'Length of output: 580
Script:
#!/bin/bash # Description: Verify the impact of removing `chainService` from `ABCIMiddleware` by searching for references to `ABCIMiddleware` in the codebase. # Test: Search for the usage of `ABCIMiddleware` in the codebase. Expect: Occurrences showing how it's used. rg --type go -A 5 $'ABCIMiddleware'Length of output: 17675
Script:
#!/bin/bash # Description: Verify the impact of removing `chainService` from `ABCIMiddleware` by searching for references to `chainService` within the context of `ABCIMiddleware`. # Test: Search for the usage of `chainService` within the context of `ABCIMiddleware` in the codebase. Expect: Occurrences showing how it's used. rg --type go -A 5 -B 5 'ABCIMiddleware.*chainService'Length of output: 55
mod/node-api/backend/mocks/validator.mock.go (1)
1-1: Version update approved.The version of the mockery tool has been updated from v2.43.2 to v2.44.1. This change does not affect the functionality or structure of the code.
mod/engine-primitives/pkg/engine-primitives/mocks/built_execution_payload_env.mock.go (1)
1-1: Version update approved.The version of the mockery tool has been updated from v2.43.2 to v2.44.1. This change does not affect the functionality or structure of the code.
mod/node-api/backend/mocks/storage_backend.mock.go (1)
1-1: Version update approved.The version of the mock generation tool, Mockery, has been updated from v2.43.2 to v2.44.1. This change does not affect the functionality of the code.
mod/node-core/pkg/components/types.go (2)
53-53: New import statement approved.The import statement for the
versionpackage has been added to support the newReportingServicetype alias.
326-327: New type alias approved.The
ReportingServicetype alias has been added to improve modularity and readability.Verify the usage of the new type alias in the codebase.
Verification successful
New type alias usage verified.
The
ReportingServicetype alias is consistently and correctly used across the codebase.
mod/node-core/pkg/components/service_registry.gomod/node-core/pkg/components/defaults.gomod/node-core/pkg/components/reporting_service.gomod/node-core/pkg/services/version/version.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the new `ReportingService` type alias in the codebase. # Test: Search for the usage of `ReportingService`. Expect: Occurrences of the new type alias. rg --type go 'ReportingService'Length of output: 1477
Script:
#!/bin/bash # Fetch context around the identified lines in the files where `ReportingService` is used. # Get context for mod/node-core/pkg/components/service_registry.go rg --type go --context 5 'ReportingService' mod/node-core/pkg/components/service_registry.go # Get context for mod/node-core/pkg/components/defaults.go rg --type go --context 5 'ReportingService' mod/node-core/pkg/components/defaults.go # Get context for mod/node-core/pkg/components/reporting_service.go rg --type go --context 5 'ReportingService' mod/node-core/pkg/components/reporting_service.go # Get context for mod/node-core/pkg/services/version/version.go rg --type go --context 5 'ReportingService' mod/node-core/pkg/services/version/version.goLength of output: 3396
mod/node-api/backend/mocks/beacon_block_header.mock.go (1)
1-1: Version update approved.The version of the mock generation tool, Mockery, has been updated from v2.43.2 to v2.44.1. This change does not affect the functionality of the code.
mod/node-api/backend/mocks/beacon_state.mock.go (1)
1-1: Mockery tool version update.The mockery tool version has been updated from
v2.43.2tov2.44.1. Ensure that this version update does not introduce any breaking changes or issues.Verification successful
Mockery tool version update verified.
The update from
v2.43.2tov2.44.1does not introduce any breaking changes or issues. The changes are primarily related to workflow improvements and additional support for certain types.
- No breaking changes identified in the changelog for v2.44.1.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if the new mockery version introduces any issues. # Test: Check for any breaking changes or issues introduced by the new version. # Expect: No issues or breaking changes. # Run go mod tidy to ensure dependencies are correctly managed. go mod tidy # Run go test to ensure all tests pass. go test ./...Length of output: 170
Script:
#!/bin/bash # Description: Check the changelog or release notes for mockery tool versions v2.43.2 and v2.44.1 to identify any breaking changes. # Fetch the changelog for mockery tool v2.43.2 curl -s https://api.github.com/repos/vektra/mockery/releases/tags/v2.43.2 | jq '.body' # Fetch the changelog for mockery tool v2.44.1 curl -s https://api.github.com/repos/vektra/mockery/releases/tags/v2.44.1 | jq '.body'Length of output: 734
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (3)
- mod/node-core/pkg/components/attributes_factory.go (1 hunks)
- mod/node-core/pkg/components/block_store.go (1 hunks)
- mod/node-core/pkg/components/types.go (2 hunks)
Additional comments not posted (4)
mod/node-core/pkg/components/attributes_factory.go (2)
31-37: Good use of struct for dependency injection.The introduction of
AttributesFactoryInputenhances code clarity and maintainability by grouping related parameters.
41-50: Improved function signature and readability.The use of
AttributesFactoryInputinProvideAttributesFactorystreamlines the function's interface and makes dependencies more explicit.mod/node-core/pkg/components/block_store.go (1)
69-69: Field reorganization inBlockPrunerInput.The
Configfield has been moved afterBlockStore, which may impact how instances are instantiated and utilized.mod/node-core/pkg/components/types.go (1)
326-326: Enhanced modularity with type aliasReportingService.The introduction of
ReportingServiceas a type alias forversion.ReportingServiceenhances modularity and readability.
Summary by CodeRabbit
New Features
DefaultNodeAPIComponents,DefaultNodeAPIHandlers, andDefaultBrokerProviders.Improvements
Refactor
ABCIMiddlewareInputand adjusted field ordering for improved clarity.