Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional PostImportScriptPath parameter to lazy-posh-git module to enable running custom script after posh-git import #2

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

Jawz84
Copy link
Contributor

@Jawz84 Jawz84 commented Sep 21, 2022

Fixes #1

This PR is intended to come up with the best solution to enable lazy-posh-git to load additional settings, after posh-git is imported.

Please feel free to make improvements, or suggestions.

Copy link
Owner

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, tested as well. Just added suggestions to rename parameter to be more generic since one could run any custom script for whatever reason, add parameter position and tweaks to docs.

lazy-posh-git.psm1 Outdated Show resolved Hide resolved
lazy-posh-git.psm1 Outdated Show resolved Hide resolved
lazy-posh-git.psm1 Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bergmeister bergmeister changed the title add posh-git settings script Add optional PostImportScriptPath parameter to lazy-posh-git module to enable running custom script after posh-git import Sep 21, 2022
@bergmeister bergmeister merged commit 6066e1f into bergmeister:main Sep 21, 2022
@Jawz84
Copy link
Contributor Author

Jawz84 commented Sep 21, 2022

Yes, nice teamwork! I agree more generic naming is better here! LGTM 🚀

@bergmeister
Copy link
Owner

🎉v0.1.0 has been released which incorporates this pull request.🎉

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to provide a way to set custom $gitpromptsettings
2 participants