Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions workflows #16

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Update GitHub Actions workflows #16

merged 7 commits into from
Jun 18, 2024

Conversation

phrdang
Copy link
Member

@phrdang phrdang commented Jun 18, 2024

  • Rename reviewdog.yml to linters.yml
  • Add Rubocop job to linters.yml: https://github.com/reviewdog/action-rubocop
  • Add .rubocop.yml config (blank file for now) and install rubocop gems
  • Add Rubocop docs to CONTRIBUTING.md
  • Set filter_mode: nofilter and fail_on_error: true for reviewdog linters so the linters check all files (not just the ones in the PR) and the CI checks show up red if there are linter errors
  • In rspec.yml change name to "Run all page tests" and run on all pushes

@phrdang phrdang self-assigned this Jun 18, 2024
@phrdang phrdang mentioned this pull request Jun 18, 2024
2 tasks
phrdang added 5 commits June 17, 2024 20:52
- `nofilter` means it will check the entire repository not just the stuff added in the most recent commit of the PR
- `fail_on_error` means the github action fails (e.g. shows up red instead of green)
@phrdang phrdang marked this pull request as ready for review June 18, 2024 04:12
@phrdang phrdang requested a review from cycomachead June 18, 2024 04:12
@cycomachead cycomachead merged commit 82377bb into main Jun 18, 2024
2 of 7 checks passed
@cycomachead cycomachead deleted the github-actions branch June 18, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants