Improved a11y specs #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…hod doesn't exist anymore for some reason In rack v3 rack/handler is removed and put in a separate gem, rackup: https://stackoverflow.com/questions/75088199/require-cannot-load-such-file-rack-handler-loaderror NOTE: rack-jekyll gem is archived https://github.com/adaoraul/rack-jekyll/tree/master Maybe when changing dependency versions the `compiling?` method became lost?
…in accessibility checks
This is probably a temporary fix because rack-jekyll is no longer maintained :( Should probably look into this instead so we can use newer versions of rack: https://nts.strzibny.name/how-to-test-static-sites-with-rspec-capybara-and-webkit/
|
Omg. I can't believe that devcontainer file had a typo. 🤣 I just copied it over from other repo. 🤦 |
|
Haha yeah I didn't catch it the first time either 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.devcontainer/to set up GitHub codespaces,devcontainer.jsonconfig andpost-create.shscript.gitignore(including removingGemfile.lockfrom it).tool-versionsand set Ruby version to 3.3.0rackupgem and specifyrack-jekyll >= 0.5.0/to hw, labs, and projects permalinks_config.ymldocs/DELETEMEdocs/a11y.yml