Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop CI taking forever #24

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Fix rubocop CI taking forever #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2b8f4f2
Add .ruby-version file
phrdang Jun 19, 2024
736aac1
Add .ruby-version at 3.3.0 to use rubocop
phrdang Jun 19, 2024
3d43af4
Run rubocop autocorrect
phrdang Jun 19, 2024
ede7a07
Set rubocop filter mode to file to attempt to fix runtime
phrdang Jun 19, 2024
2519397
Try reverting rubocop config to fix runtime
phrdang Jun 19, 2024
c7c406a
Add rubocop-rspec to rubocop config
phrdang Jun 19, 2024
c3abab1
Exclude spec from jekyll build
phrdang Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/linters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ jobs:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
bundler-cache: true
- uses: reviewdog/action-rubocop@v2
with:
Expand Down
3 changes: 0 additions & 3 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,3 @@ require:

AllCops:
NewCops: enable
Exclude:
- '_site/**/*'

1 change: 1 addition & 0 deletions .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.3.0
3 changes: 2 additions & 1 deletion _config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,5 @@ exclude:
- "vendor"
- "README.md"
- "CONTRIBUTING.md"
- "LICENSE"
- "LICENSE"
- "spec"
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
options.add_argument('--disable-dev-shm-usage')
options.add_argument('--window-size=1400,1400')

Capybara::Selenium::Driver.new(app, browser: :chrome, options: options)
Capybara::Selenium::Driver.new(app, browser: :chrome, options:)
end

# Change default_driver to :selenium_chrome if you want to actually see the tests running in a browser locally.
Expand Down
Loading