-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use mio_serial repo using serialport-rs 2.0.0 #3
Conversation
Once we get berkowski/mio-serial#1 into it's own branch I'd like to do the same here. You can adjust the dependency target in |
Cargo.toml
Outdated
@@ -16,5 +16,4 @@ futures = "0.1" | |||
tokio-core = "0.1" | |||
tokio-io = "0.1" | |||
bytes = "0.4" | |||
mio = "0.6" | |||
mio-serial = "0.5" | |||
mio-serial = { git = "https://github.com/berkowski/mio-serial" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to mio-serial = { git = "https://github.com/berkowski/mio-serial", branch = "serialport-2"
}
Please switch PR target to the new |
Branches are moved to Tests are better, it's just errors from |
serialport-rs 2.0 was just released. |
Yup! Moving forward this week when I've got time. |
Merging now that |
Following berkowski/mio-serial#1, it uses the new error type from
mio-serial
.I removed
mio
dependency as it is not used directly in this crate.