Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mio_serial repo using serialport-rs 2.0.0 #3

Merged
merged 1 commit into from
Feb 25, 2018

Conversation

ndusart
Copy link
Contributor

@ndusart ndusart commented Jul 25, 2017

Following berkowski/mio-serial#1, it uses the new error type from mio-serial.

I removed mio dependency as it is not used directly in this crate.

@berkowski
Copy link
Owner

Once we get berkowski/mio-serial#1 into it's own branch I'd like to do the same here. You can adjust the dependency target in Cargo.toml accordingly to see how things build against the branched mio-serial, and we can track upstream fixes until things are ready to merge back into master.

Cargo.toml Outdated
@@ -16,5 +16,4 @@ futures = "0.1"
tokio-core = "0.1"
tokio-io = "0.1"
bytes = "0.4"
mio = "0.6"
mio-serial = "0.5"
mio-serial = { git = "https://github.com/berkowski/mio-serial" }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to mio-serial = { git = "https://github.com/berkowski/mio-serial", branch = "serialport-2" }

@berkowski
Copy link
Owner

Please switch PR target to the new serialport-2 branch and update the mio-serial dependency to point at the similarly named branch. Should get some better test results.

@ndusart ndusart changed the base branch from master to serialport-2 July 31, 2017 08:11
@ndusart
Copy link
Contributor Author

ndusart commented Jul 31, 2017

Branches are moved to serialport-2.

Tests are better, it's just errors from mio-serial bubbling up here.

@Susurrus
Copy link

serialport-rs 2.0 was just released.

@berkowski
Copy link
Owner

Yup! Moving forward this week when I've got time.

@berkowski
Copy link
Owner

Merging now that serialport-2 branch for mio-serial has been merged to master.

@berkowski berkowski merged commit 8798f26 into berkowski:serialport-2 Feb 25, 2018
@ndusart ndusart deleted the serialport-2 branch February 27, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants