Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place display name between quotes after decoding. #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kermer
Copy link

@Kermer Kermer commented Jan 4, 2018

Closes #70

@jstedfast
Copy link

jstedfast commented Jan 4, 2018

This patch is also wrong. You can't just put quotes around the content of each decoded blob in the output string.

What if you have something like this?

To: =?iso-8859-1?B?<base64>?= =?iso-8859-1?B?<base64>?= <user@gmail.com>

You might end up with: "FirstName" "LastName" <user@gmail.com>

You're also removing any single and double quote characters from the decoded output which is not a good idea because they may be significant. Remember: the idea is that the resulting DisplayName of the parsed address should be identical to what the user typed in the sending client (WYSIWYG).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants