fix gradle scripts, update documentation, add support for SHA-256 hashes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Maier <pmaier@sysmocom.de>
The url uses git@github.com, which seems not to work anymore, let's use https://github.com (as suggested by Luca Weiss <luca.weiss@fairphone.com>)
Unfortunately jcenter was shut down on August 15th, 2024, mavenCentral is the recommended alternative.
Several artifacts required for building are no longer available since bintray shut down. While almost all required artifacts are available through alternative sources (mavenCentral and javacard.pro), jcardsim seems to be no longer available anywhere. (jcardsim is needed for to run the provided unittests) Fortunately jcardsim has been archived, so let's configure the url so gradle can fetch it again.
The provided gradle wrapper is outdated, so let's regenerate it.
The README.md needs needs an overhaul, some links are broken and the commandlines to build the applet have slightly changed.
For storing SHA-256 signatures we need to increase the size to 32 bytes. The previous 20 bytes were for SHA-1. Signed-off-by: Philipp Maier <pmaier@sysmocom.de>
The applet now also supports SHA-256 hashes. Let's update the documentation accordingly.
|
Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Mr. Martel,
we are using your ara-m applet in our sysmoISIM / sysmoUSIM cards for quite some time now. For us and the users of our simcards it is a very useful piece of software. In particular in the development and research context it is very helpful to have a freely configurable ara-m applet.
Thank you for contributing your applet to the public!
In the fork I have created I have picked up the suggestions from martinpaljak and z3ntu. I also did a bit of cleanup and fixing to the gradle scripts and updated the documentation. The applet now supports SHA-256 hashes (z3ntu) and
should build again.
Please note that we use the github repository as a mirror, the primary repositoy (where we do our development) can be found under: https://gitea.osmocom.org/sim-card/aram-applet
best regards,
Philipp Maier