Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry pick PR 1289 for error handling #3

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jefft0
Copy link

@jefft0 jefft0 commented Oct 24, 2023

This PR is against branch with-go-PRs.

After this PR is merged, we will update the replace in the go.mod of gnomobile to use the latest branch with-go-PRs.

…s.As in IsErrWrongPassword. See the PR.

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@D4ryl00 D4ryl00 changed the title Chore: Cherry pick PR 1289 for error handling chore: Cherry pick PR 1289 for error handling Oct 24, 2023
@jefft0 jefft0 merged commit c0cef2f into with-gno-PRs Oct 24, 2023
81 of 83 checks passed
@jefft0 jefft0 deleted the chore/cherry-pick-PR-1289 branch October 24, 2023 14:54
@guardrails
Copy link

guardrails bot commented Oct 24, 2023

⚠️ We detected 2 security issues in this pull request:

Vulnerable Libraries (2)
Severity Details
High pkg:golang/golang.org/x/net@v0.17.0 upgrade to: > v0.17.0
High pkg:golang/golang.org/x/crypto@v0.14.0 upgrade to: > v0.14.0

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants