fix: manually copy API files in build/api folder #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuricmp
reviewed
Oct 24, 2024
package.json
Outdated
| @@ -7,6 +7,7 @@ | |||
| "type": "module", | |||
| "scripts": { | |||
| "build": "expo-module build", | |||
| "postbuild": "sh postbuild.sh", | |||
There was a problem hiding this comment.
did you tried the postinstall (link)
If it works, you won't need to update Makefile and release.yml because it will run automatically after yarn or yarn install command.
There was a problem hiding this comment.
Finally putting the code in the prepare stage is better: https://docs.npmjs.com/cli/v10/using-npm/scripts#life-cycle-scripts
D4ryl00
force-pushed
the
fix/api-file-missing
branch
from
bb6fb30
to
7cf00c0
Compare
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
D4ryl00
force-pushed
the
fix/api-file-missing
branch
from
7cf00c0
to
7a09465
Compare
|
Tested on Android and iOS, with new expo app ( |
iuricmp
approved these changes
Oct 24, 2024
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing
yarnoryarn installcreates abuilddirectory with compiled files, but omits to includesrc/api/rpcmanager.pb.d.ts,src/api/rpcmanager.pb.js,src/api/protocoltypes.pb.d.tsandsrc/api/protocoltypes.pb.jsintobuild/api.So when a third app installs weshnet-expo as a dependency,
build/api/index.jscan't find those files and returns an error.This PR add a new package.json script to copy those files into the
build/apifolder`. This script is added in the Makefile and in the Github Action release workflow.