Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: move push notification stuff into berty messenger #48

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

D4ryl00
Copy link
Collaborator

@D4ryl00 D4ryl00 commented Mar 30, 2023

This PR moves all the push notification stuff into Berty Messenger.

@guardrails
Copy link

guardrails bot commented Mar 30, 2023

⚠️ We detected 1 security issue in this pull request:

Insecure Network Communication (1)
Severity Details CWE Docs Course
Medium Title: Insecure gRPC server connection
s := grpc.NewServer()
N/A 📚

More info on how to fix Insecure Network Communication in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@D4ryl00 D4ryl00 marked this pull request as draft March 30, 2023 10:22
@D4ryl00 D4ryl00 changed the title Chore/move push notification into berty messenger WIP Chore/move push notification into berty messenger Mar 30, 2023
@D4ryl00 D4ryl00 changed the title WIP Chore/move push notification into berty messenger WIP Chore: move push notification stuff into berty messenger Mar 30, 2023
@jefft0 jefft0 removed request for a team April 19, 2023 08:35
@jefft0 jefft0 removed the 🚧 WIP label Apr 21, 2023
@D4ryl00 D4ryl00 force-pushed the chore/move-push-into-berty branch from 9e53981 to dcd3321 Compare June 8, 2023 09:54
@D4ryl00 D4ryl00 force-pushed the chore/move-push-into-berty branch 4 times, most recently from acd3d5e to 086a66c Compare June 26, 2023 10:20
@D4ryl00 D4ryl00 force-pushed the chore/move-push-into-berty branch from f04eaae to 82947d7 Compare June 30, 2023 14:51
@D4ryl00 D4ryl00 force-pushed the chore/move-push-into-berty branch 2 times, most recently from e59cd52 to f4ad470 Compare July 18, 2023 23:01
…h notification stuff in Berty

Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
@D4ryl00 D4ryl00 force-pushed the chore/move-push-into-berty branch from f4ad470 to 6c00f4d Compare July 20, 2023 08:43
@D4ryl00 D4ryl00 changed the title WIP Chore: move push notification stuff into berty messenger Chore: move push notification stuff into berty messenger Jul 20, 2023
@D4ryl00 D4ryl00 marked this pull request as ready for review July 20, 2023 08:54
Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

outofstoremessage_test.go Outdated Show resolved Hide resolved
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
@D4ryl00 D4ryl00 force-pushed the chore/move-push-into-berty branch from 6c00f4d to 827c8ea Compare July 21, 2023 12:03
@D4ryl00 D4ryl00 merged commit 89c06bb into berty:main Jul 21, 2023
@D4ryl00 D4ryl00 deleted the chore/move-push-into-berty branch July 21, 2023 12:43
@github-actions
Copy link

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants