Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add API functions ShareContact and DecodeContact #87

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

jefft0
Copy link
Contributor

@jefft0 jefft0 commented Jun 27, 2023

Add these API methods to do the Protobuf encoding/decoding so that the Wesh application doesn't need to use gogo proto.

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
@jefft0 jefft0 marked this pull request as ready for review June 27, 2023 08:31
@jefft0 jefft0 requested a review from D4ryl00 June 27, 2023 08:32
Copy link
Collaborator

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefft0 jefft0 closed this Jun 27, 2023
@jefft0 jefft0 deleted the feat/API-add-ShareContact-DecodeContact branch June 27, 2023 09:02
@jefft0 jefft0 restored the feat/API-add-ShareContact-DecodeContact branch June 27, 2023 09:03
@jefft0 jefft0 reopened this Jun 27, 2023
@jefft0 jefft0 merged commit 289dbdc into berty:main Jun 27, 2023
22 of 23 checks passed
@jefft0 jefft0 deleted the feat/API-add-ShareContact-DecodeContact branch June 27, 2023 09:03
@github-actions
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants