fix: Make API messages names be the same as their event #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM :) |
n0izn0iz
approved these changes
Jun 27, 2023
jefft0
force-pushed
the
fix/API-events-same-name-as-message
branch
from
9c24564
to
b23ac5c
Compare
…ent. Fixes berty#79. Signed-off-by: Jeff Thompson <jeff@thefirst.org>
jefft0
force-pushed
the
fix/API-events-same-name-as-message
branch
from
b23ac5c
to
41e4e1d
Compare
|
🎉 This PR is included in version 1.12.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #79. See the issue for rationale. Change all message names to be the same as the event that sends it. Update the name of related functions that process the event message.
This is a BREAKING CHANGE to the API. Other packages like Berty will need to update the message names.