fix: use ipfs datastore as root datastore for persistent service #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0izn0iz
reviewed
Jun 27, 2023
service_client.go
Outdated
| repo, err := ipfsutil.LoadRepoFromPath(path) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| // use ipfs root datastore | ||
| opts.RootDatastore = repo.Datastore() |
There was a problem hiding this comment.
you should probably create a namespaced datastore from the ipfs datastore
There was a problem hiding this comment.
you totally right, thanks !
gfanton
force-pushed
the
fix/root-ds
branch
2 times, most recently
from
8b3c757
to
5e9bd08
Compare
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
|
The deadlock mentioned in the description isn't related to Badger. We haven't reproduced the bug. Closing this PR without merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
badger create some deadlock with store message for an unknown reason, use ipfs main datastore as root datastore for now