In NewService, optionally set opts.RootDatastore to a persistent data store #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefft0
changed the title
D4ryl00
requested changes
Aug 1, 2023
…pplyDefaultsGetDatastore. Return error from applyDefaultsGetDatastore. Signed-off-by: Jeff Thompson <jeff@thefirst.org>
…s.DatastoreDir. Use this in NewServiceClient. Signed-off-by: Jeff Thompson <jeff@thefirst.org>
jefft0
force-pushed
the
feat/opts.RootDatastore-default
branch
from
7482de4
to
73658cf
Compare
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has two commits. The first commit cleans up
Opts.applyPushDefaults: It doesn't need to callapplyDefaultsGetDatastoreagain, and it doesn't return an error. Also makeapplyDefaultsGetDatastorereturn an error, in preparation for the next commit. This commit does not change any functionality.The second commit updates
Opts.applyDefaultsGetDatastore(called byNewService) to optionally setopts.RootDatastoreto a persistent data store atopts.DatastoreDir. This uses the same code for a Badger database that we move fromNewPersistentServiceClient(and which is now simpler).