-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed bower dependency #10
base: master
Are you sure you want to change the base?
Conversation
removed unneeded bower dependency. bessdsv#8
+1 |
2 similar comments
👍 |
👍 |
It is sad that I need to give a 👍 for an issue thas is known for almost a year. |
@bessdsv If you aren't able to merge this important PR and fix issues, could you please consider to add some contributors to do so? |
I use those dependencies for installing last versions of internal libraries (jquery & jasmine-jquery) and make some magic. |
You don't need to bring in Bower as a dependency. If you list the dependencies you need (such as jQuery and jasmine-jquery) in the package config (as well as the bower.json), then if you're pulling the library down with bower, jspm, or whatever, it should pull down any needed dependencies. And from what you're telling me, it sounds like you use bower as a dev-dependency, so in that case it definitely shouldn't be included. What goes out the the end use should only be what's needed for the actual project, ideally. |
Bump |
Totally agree with @AStoker . Would be nice to get rid of bower; and then allso the custom install-script of this, otherwise, well working plugin |
@bessdsv, any update? Is there any new development on this repo? |
@julmot, can do |
@julmot patch-1 branch of the fork has been merged with the master, and a release has been made. https://github.com/AStoker/karma-jasmine-jquery/ |
@bessdsv if this ever get's merged in, I'll mark the branch I created as deprecated (but leave it up) and point it back to the master. |
@bessdsv Take care of this issue. |
@bessdsv Please also specify where exactly you need that bower dependency. I searched your code for any bower call unsuccessfully. |
bump |
Thanks @AStoker. I'm reviving an old project and this package was causing npm install to fail for me. Moving to |
If anyone's interested I published karma-jasmine-jquery. The package has no dependencies and let you choose your version of |
You don't have to move anything, just fork, make the change and adapt your
|
@bessdsv , can you merge either this PR or #16. There is a lot of
Full Report - |
removed unneeded bower dependency.
#8