-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Null Safety #264
base: master
Are you sure you want to change the base?
Conversation
+1 |
@jzoom can it be merged anytime soon? It is blocking my release |
@Arkangel12 Could you pls publish the package onto pub.dev? The repo owner may not continue the repo anymore. |
@jzoom, @pepsighan, @iChenLei, @jogboms Could anyone review and merge this PR please? |
Any chance to get this merged soon? It's one of the dependencies holding me up from migrating to null-safety. |
@allanwolski @szymly @emlynmac @Nobler I am tring to contact with jzoom, and push the merge action as soon as possible. |
@iChenLei Any updates? |
Many thanks anyway. I will temporarily depend directly on the package stored in @Arkangel12 Github. Any others can do that before this pr will be merged: flutter_swiper:
git:
url: git@github.com:Arkangel12/flutter_swiper.git
ref: master |
@Nobler @allanwolski @Arkangel12 @emlynmac I am sorry to say this PR is look likes can't be merged. Please use alternative solution(e.g. I contact with jzoom first time at 2021.05.13. After two weeks he still not merge this PR.
So I left this comment for everyone who need flutter-swiper and null-safety support, please use alternative solution. Thanks |
@iChenLei Thank you so much for your help! This pr will be merged soon, I guess.👀
|
@iChenLei @jzoom he could just upload a fixed version to pub, no need for github 😅️ maybe it would be worth thinking about proposing the package to be transferred to https://github.com/fluttercommunity/transfer-guide 🤔️ |
any updates on this? |
This is died it seems. |
I have forked this repo and merged most of PRs into it (including this one). You can find the package here: https://pub.dev/packages/card_swiper |
Unfortunately, you have no open issues, it is working fine for now, but it still has some problems yets a we warned in two issues in another fork repository: pzentenoe/flutter_card_swipper#4, pzentenoe/flutter_card_swipper#3 (comment) |
Thanks @SalahAdDin, |
You can try the following version dependencies: |
You can try the following version dependencies: |
You can try the following version dependencies: |
@lianyagang @TheAnkurPanchani @pzentenoe why don't you try to gather all your sources and work on a unique fork? |
i think u can try use this pub gather all resource best wish for u |
Can anyone confirm if I can use this dependency 'flutter_swiper' with null-safety support? I saw in the dev pub that it doesn't support null-safety. How do I make it support null safety? |
use it flutter_swiper_null_safety: ^1.0.2 |
@lianyagang thanks for the answer. The dependency that you suggest is a fork of "flutter_swiper"? What is your opinion about "card_swiper"? |
I help a little bit by migrating this package to null safety please take a look.
I copy the code from your other packages (they were too old) and added in this one, the others can be migrated later I just have enough time to do it like this.
please double-check if it is ok to move this to version
2.0.0
this was a huge refactor and some code was enhanced (I addedpedantic
) but it also can only be changed to1.2.0
i leave this to you.let me know what do you think 👍