Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy fabirc-operator by helm #2

Merged
merged 1 commit into from
Feb 8, 2023
Merged

feat: deploy fabirc-operator by helm #2

merged 1 commit into from
Feb 8, 2023

Conversation

0xff-dev
Copy link
Contributor

@0xff-dev 0xff-dev commented Dec 26, 2022

feat: deploy fabirc-operator by helm
Fix: #1
Fix: #4

@bjwswang
Copy link
Member

@0xff-dev should place fabric-operator helm charts under root directory ,but is under ./fabric-operator/fabric-operator.

@bjwswang
Copy link
Member

@0xff-dev update project's primary README.md at part 2. Install baas-component

fabirc-operator/fabric-operator/README.md Outdated Show resolved Hide resolved
fabirc-operator/values.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
fabirc-operator/README.md Outdated Show resolved Hide resolved
fabirc-operator/README.md Outdated Show resolved Hide resolved
Copy link
Member

@Abirdcfly Abirdcfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some Nits. but LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated
```shell
$ kubectl get po -noperator-system
NAME READY STATUS RESTARTS AGE
controller-manager-5d6449b864-ckf25 1/1 Running 0 55s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just to install the operator, what should we do once the operator is installed?
If we just need to install bc-console after operator, then it should be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the documentation for installing bc-console, but at the moment it looks like the bc-console project installation documentation is very simple and I'm not sure if it will install properly. It should be determined with the front-end developers or they should provide the installation documentation for bc-console.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change operator-system to baas-system, and check with pencheng about which bc-console image we should use, we should add a workable version with console, so the user can try it easily.

fabirc-operator/values.yaml Outdated Show resolved Hide resolved
fabirc-operator/values.yaml Outdated Show resolved Hide resolved
fabirc-operator/values.yaml Outdated Show resolved Hide resolved
@0xff-dev 0xff-dev marked this pull request as draft January 29, 2023 06:05
@0xff-dev 0xff-dev marked this pull request as ready for review February 1, 2023 05:56
@0xff-dev
Copy link
Contributor Author

0xff-dev commented Feb 2, 2023

The current local kind cluster test does not work without removing the readinessProbe.

@Abirdcfly
Copy link
Member

Abirdcfly commented Feb 2, 2023

The current local kind cluster test does not work without removing the readinessProbe.

@0xff-dev @bjwswang @nkwangleiGIT
This problem can be reproduced in an offline environment or on github aciton:
https://github.com/bestchains/fabric-operator/actions/runs/4072338261/jobs/7014987324

We can see that by default, pod oidc-server-5b5b55fff4-6qnj5 in ns u4a-system is always not ready.log in this line Describe pod oidc-server-5b5b55fff4-6qnj5 displays Readiness probe failed: HTTP probe failed with statuscode: 400log in this line. After deleting the readinessProbe in container oidc-server, this pod is ready. In the local environment, we can get the user's token then.

@bjwswang
Copy link
Member

bjwswang commented Feb 2, 2023

@0xff-dev Can we see the console web pages after login?

@0xff-dev
Copy link
Contributor Author

0xff-dev commented Feb 2, 2023

@0xff-dev Can we see the console web pages after login?

Theoretically speaking, it is accessible, and the deployment form is the same as our local test environment. I need to test it.

README.md Outdated Show resolved Hide resolved
scripts/e2e.sh Show resolved Hide resolved
fabric-operator/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
scripts/kind.sh Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
fabric-operator/values.yaml Outdated Show resolved Hide resolved
@0xff-dev 0xff-dev marked this pull request as draft February 8, 2023 09:29
@0xff-dev 0xff-dev marked this pull request as ready for review February 8, 2023 09:30
Copy link
Member

@bjwswang bjwswang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync webhooks from fabric-operator develop fabric-operator installer
5 participants