-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deploy fabirc-operator by helm #2
Conversation
fabirc-operator/fabric-operator/crds/iam.tenxcloud.com_users.yaml
Outdated
Show resolved
Hide resolved
@0xff-dev should place |
@0xff-dev update project's primary README.md at part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some Nits. but LGTM
README.md
Outdated
```shell | ||
$ kubectl get po -noperator-system | ||
NAME READY STATUS RESTARTS AGE | ||
controller-manager-5d6449b864-ckf25 1/1 Running 0 55s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just to install the operator, what should we do once the operator is installed?
If we just need to install bc-console after operator, then it should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add the documentation for installing bc-console
, but at the moment it looks like the bc-console
project installation documentation is very simple and I'm not sure if it will install properly. It should be determined with the front-end developers or they should provide the installation documentation for bc-console.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change operator-system to baas-system, and check with pencheng about which bc-console image we should use, we should add a workable version with console, so the user can try it easily.
The current local kind cluster test does not work without removing the |
@0xff-dev @bjwswang @nkwangleiGIT We can see that by default, pod |
@0xff-dev Can we see the console web pages after login? |
Theoretically speaking, it is accessible, and the deployment form is the same as our local test environment. I need to test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
feat: deploy fabirc-operator by helm
Fix: #1
Fix: #4