Better tracked move history #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still needs a bit of formatting work and testing.
Fellshadow
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Looks fine to me, just a couple of small questions
Also leaving this open for now since i've merged the other two smaller PRs in, to let you update this branch with those changes / check for conflicts (shouldn't be any i think but worth double-checking that this at least won't undo any of the other PRs lol)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #202
This adds support for tracking more useful information about moves used during battle. In addition, it allows viewing all tracked moves for any given Pokémon, not just the last four seen.
The negative/positive move box color highlights are the same that are shown in the Pokemon Info lookup page, where it bases it off of the currently viewed Pokemon. Since, that info is most helpful when you are fighting something, or using your own Pokemon in battle.