Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code to track initial moveset of Pokemon used #494

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

UTDZac
Copy link
Collaborator

@UTDZac UTDZac commented Nov 18, 2024

This solves an outstanding issue where the initial 4 moves of a player's lab/pivot Pokemon are never tracked, since the conditions for tracking a move were "used in battle" or "learned while leveling up".

This remedies that issue by doing a 1-time tracking of the current moveset when battling a trainer (player decided to run this Pokemon for real). It also only tracks moves within its initial moveset if that Pokemon could have naturally learned that move by level up.

Before 1st Trainer Battle

image

After 1st Trainer Battle

image

This solves an outstanding issue where the initial 4 moves of a player's lab/pivot Pokemon are never tracked, since the conditions for tracking a move were "used in battle" or "learned while leveling up".

This remedies that issue by doing a 1-time tracking of the current moveset when battling a trainer (player decided to run this Pokemon for real). It also only tracks moves within its initial moveset if that Pokemon could have naturally learned that move by level up.
@UTDZac UTDZac self-assigned this Nov 18, 2024
Copy link
Collaborator

@jtigues jtigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Noting that there is a minor chance for unknown information being revealed for your second pokemon in double battles, but for the most part won't come up, and won't matter.

@UTDZac UTDZac merged commit 27ed257 into dev Nov 18, 2024
@UTDZac UTDZac deleted the track-initial-pokemon-moveset branch November 18, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants