New Feature: Game Profiles for New Runs #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding in some core functionality
Previously, the auto-saved tracker data file (TDAT) was based on the game version being played. This causes issues when a player wanted to play many different FireRed games and have data for each. This change allows different game profiles to each have their own TDAT file for their tracker notes and data.
Certain characters are restricted and not allowed for file names.
The main issue was setting the default value of the `overwrite` parameter
Fix: - cant save profile if name remains the same - prevent changing mode for existing profile (force delete/re-add) - update tdat filename if profile name changes
Two fixes: - always use the number on the rom name as the initial seed count (dont ignore "1") - only use bizhawk rom name if that rom exists in the Roms Folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #450
This feature adds the ability to create, manage, and use different New Run setup profiles for different games or rulesets. This has been a highly requested feature, especially for people who play different Ironmon rulesets all the time.
In short, it works similar to how New Run setup worked in the past, but all of the settings are saved as a Profile object. All profiles are stored within a
NewRunProfiles.json, located in theironmon_trackerfolder.In addition to storing the New Run settings as a profile, this PR also changes how Tracker Notes Data (
.TDATfiles) are saved. Previously, it was saved as a single file for a single game version (such as Fire Red). Now, it saves a file for each profile, allowing for multiple "Fire Red" data files if more than one profile is using the Fire Red game version. These files are stored in thetracker_notesfolder (new as of this PR).Example: List of Profiles
Example: Active Profile
Example: Adding or Editing a Profile