Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: soap_fault:parse_fault_1_1 funciton_clause #24

Open
define-null opened this issue Jan 19, 2017 · 4 comments
Open

bug: soap_fault:parse_fault_1_1 funciton_clause #24

define-null opened this issue Jan 19, 2017 · 4 comments

Comments

@define-null
Copy link
Contributor

soap_fault module fails on parsing xml that looks like this

<soap:Envelope xmlns:soap=\"http://schemas.xmlsoap.org/soap/envelope/\">
<soap:Body>
<soap:Fault>
  <faultcode>soap:Server</faultcode>
  <faultstring>Some description goes here</faultstring>
  <detail><ns2:SomeTag xmlns:ns2=\"http://some_namespace_goes_here/\">
             <tag1>something</tag1>
             <tag2>something else</tag2>
         </ns2:SomeTag>
  </detail>
</soap:Fault>
</soap:Body>
</soap:Envelope>

The stacktrace looks like:

  "stacktrace" : [
    "{soap_fault,parse_fault_1_1, [{startElement,[],\"tag1\",[],[]}, 
[{\"ns2\",\"http://some_namespace_goes_here/\"},
{\"soap\",\"http://schemas.xmlsoap.org/soap/envelope/\"}],             
{pf_state,'1.1',detail,[], {faultcode,\"http://schemas.xmlsoap.org/soap/envelope/\",\"Server\",undefined}, \"Some description goes here\", undefined,[],undefined,  {\"SomeTag\",\"http://some_namespace_goes_here\"}, []}], [{file,\"src/soap_fault.erl\"},{line,327}]}",
    "{soap_client_util,xml_parser_cb,2,[{file,\"src/soap_client_util.erl\"},{line,421}]}",
    "{erlsom_sax_utf8,wrapCallback,2,[{file,\"src/erlsom_sax_utf8.erl\"},{line,1408}]}",
    "{erlsom_sax_utf8,parseContentLT,2,[{file,\"src/erlsom_sax_utf8.erl\"},{line,936}]}",
    "{erlsom_sax_utf8,parse,2,[{file,\"src/erlsom_sax_utf8.erl\"},{line,196}]}",
    "{soap_client_util,parse_xml,9,[{file,\"src/soap_client_util.erl\"},{line,259}]}",
    ...
@define-null
Copy link
Contributor Author

So I guess the proper fix for this would lead to non-compatible change as it also requires changes to soap_fault types. Any plans to fix this?

deadtrickster added a commit to deadtrickster/soap that referenced this issue Feb 9, 2018
@deadtrickster
Copy link

I addressed this issue here: deadtrickster@1b85a23

@baladzhova
Copy link

Hey, there. I am having the same problem. Is there going to be a fix soon?

@define-null
Copy link
Contributor Author

define-null commented May 28, 2018

@deadtrickster Have you finished with that fix? Maybe create a pullrequest towards this repo, or https://github.com/willemdj/soap ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants