Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Bug with google-protobuf-3.25.2-x86_64-linux #313

Closed
rwaffen opened this issue Feb 28, 2024 · 4 comments
Closed

CI Bug with google-protobuf-3.25.2-x86_64-linux #313

rwaffen opened this issue Feb 28, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@rwaffen
Copy link
Member

rwaffen commented Feb 28, 2024

google-protobuf-3.25.2-x86_64-linux is incopatible with ruby 3.3.0. Somehow this got throught without us noticing while doing the update of ruby ¯_(ツ)_/¯

this has the effect that our ci steps are failing which use the Gemfile and try to install the protobuf gem
@rwaffen rwaffen added the bug Something isn't working label Feb 28, 2024
@rwaffen
Copy link
Member Author

rwaffen commented Feb 28, 2024

see: https://github.com/betadots/hdm/actions/runs/8081337150/job/22079660537?pr=312
#312 (comment)

@oneiros
Copy link
Collaborator

oneiros commented Mar 1, 2024

I had to fix this in the branch issue-264 while rebasing against main. So this should go away when #283 is merged.

marcusdots added a commit that referenced this issue Mar 1, 2024
@marcusdots
Update google-protobuf to 3.25.3 to be compatible with ruby-3.3.0
d30e410 
Fix: #313
marcusdots added a commit that referenced this issue Mar 1, 2024
@marcusdots
Update google-protobuf to 3.25.3 to be compatible with ruby-3.3.0
1d7441c 
Fix: #313
@marcusdots marcusdots mentioned this issue Mar 1, 2024
Closed
@rwaffen
Copy link
Member Author

rwaffen commented Mar 1, 2024

we also fixed it in #315 🤦 😄

@rwaffen rwaffen closed this as completed in 6383f03 Mar 1, 2024
@rwaffen
Copy link
Member Author

rwaffen commented Mar 1, 2024

Fixed by #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update google-protobuf to 3.25.3 to be compatible with ruby-3.3.0 betadots/hdm
2 participants
@oneiros @rwaffen