Upgrade data attributes to turbo syntax #109 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opposed to the old jquery-rails style.
It looks like I did not include
jquery-railsinto the javascript bundle after upgrading to Rails 7. This resulted in the user deletion button not working.The missing functionality has since been integrated into the
turbolibrary, sojquery-railsis not strictly needed anymore. I upgraded the syntax to work with turbo.Fixes #109.
(We should probably also remove the
jquery-railsgem fromGemfile, but I would like to wait until after #106 has been merged, to avoid merge conflicts.)