Allow custom lookup functions #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest security fixes for rails plus a bunch of minor updates.
We do not (and cannot support) custom lookup functions per se, but in case they map cleanly to an existing backing, e.g. eyaml, this allows to specify this mapping, so everything should then work as expected.
rwaffen
previously approved these changes
Jul 5, 2023
tuxmea
previously approved these changes
Aug 10, 2023
rwaffen
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the solution outlined in #162 (comment)
I am still not convinced this addition is a sensible one. It only makes sense in a scenario where a custom lookup function behaves exactly like an existing backend. And I wonder if this a) is a common enough scenario to want to support it and b) makes sense in the first place. (Why would you have a custom lookup function if it is 100% equivalent to an existing one?)
Of course, currently HDM makes no actual "lookup", so I can imagine that there could be a custom lookup function based on e.g. eyaml, that is still useful to treat as (vanilla) eyaml in HDM, but will behave differently in hiera 🤷
Please note that since I have no access to an environment with such a function, I have not tested this in a "real world" scenario.
(This branch is based off #164 which should be merged first)
Fixes #162