Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker env #22

Merged
merged 16 commits into from
Apr 7, 2022
Merged

Update docker env #22

merged 16 commits into from
Apr 7, 2022

Conversation

rwaffen
Copy link
Member

@rwaffen rwaffen commented Apr 6, 2022

  • switch from ruby:2.5.8 to ruby:2.5.8-alpine as base image
  • try to minimize container build image
  • ad examples how to use docker image
  • add github action to build docker image and release as ghcr.io package
  • add Vagrantfile as local dev instance if macOS docker does not work

tuxmea
tuxmea approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@tuxmea tuxmea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

bastelfreak
bastelfreak reviewed Apr 7, 2022
View reviewed changes
DOCKER.md Outdated Show resolved Hide resolved
@rwaffen @bastelfreak
use facts hash instead of top scope
d05a7d5 
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
@rwaffen rwaffen merged commit 854a19a into betadots:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxmea tuxmea tuxmea approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

@SimonHoenscheid SimonHoenscheid Awaiting requested review from SimonHoenscheid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwaffen @bastelfreak @tuxmea