Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two very basic system tests #373

Merged
merged 2 commits into from
May 7, 2024
Merged

Add two very basic system tests #373

merged 2 commits into from
May 7, 2024

Conversation

oneiros
Copy link
Collaborator

@oneiros oneiros commented May 2, 2024

Fixes #367

@rwaffen You might want to have a look. These are the two cases we talked about, but if you look at the code I think you will find that adding additional cases should not be too hard.

The only "real" obstacle here was that I had to create a little helper method for the "slim-select" widget we use for dropdowns. But this is solved now and can be reused easily.

@oneiros oneiros requested a review from a team as a code owner May 2, 2024 13:50
@bastelfreak
Copy link
Member

@oneiros are those also executed by bundle exec rake test:all or do we need to adjust our CI config?

@oneiros
Copy link
Collaborator Author

oneiros commented May 2, 2024

are those also executed by bundle exec rake test:all or do we need to adjust our CI config?

They are! No adjustments needed. Only bundle exec rake test or the more modern bin/rails test without the :all will omit the system tests.

@bastelfreak bastelfreak added the enhancement New feature or request label May 2, 2024
@rwaffen
Copy link
Member

rwaffen commented May 2, 2024

uh, that's nice and simple. i like simple things 😃

@oneiros oneiros merged commit 08f5924 into main May 7, 2024
11 checks passed
@oneiros oneiros deleted the issue-367 branch May 7, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic system tests
3 participants