refactor: création de sms-service (separation des responsabilités)

backend/lib/sms-service.ts

@@ -0,0 +1,24 @@
+import axios from "axios"
+import config from "../config/index.js"
+
+export async function renderAndSendSimulationResultsSms(followup) {
+  try {
+    const username = config.smsService.username
+    const password = config.smsService.password
+    if (!username || !password) {
+      throw new Error("Missing SMS service credentials")
+    }
+    const renderUrl = followup.renderSimulationResultsSmsUrl(username, password)
+    const axiosInstance = axios.create({
+      timeout: 10000,
+    })
+    const { data, status } = await axiosInstance.get(renderUrl)
+    if (status !== 200 || data.responseCode !== 0) {
+      throw new Error(`SMS request failed. Body: ${JSON.stringify(data)}`)
+    }
+    return data.messageIds[0]
+  } catch (err) {
+    console.error(err)
+    throw err
+  }
+}

backend/models/followup.ts

@@ -11,6 +11,7 @@ import config from "../config/index.js"
 import { Followup } from "../../lib/types/followup.d.js"
 import { FollowupModel } from "../types/models.d.js"
 import { phoneNumberFormatting } from "../../lib/phone-number.js"
+import { renderAndSendSimulationResultsSms } from "../lib/sms-service.js"
 
 const FollowupSchema = new mongoose.Schema<Followup, FollowupModel>(
   {
@@ -114,20 +115,8 @@ FollowupSchema.method(
 
 FollowupSchema.method("sendSimulationResultsSms", async function () {
   try {
-    const username = config.smsService.username
-    const password = config.smsService.password
-    if (!username || !password) {
-      throw new Error("Missing SMS service credentials")
-    }
-    const renderUrl = this.renderSimulationResultsSmsUrl(username, password)
-    const axiosInstance = axios.create({
-      timeout: 10000,
-    })
-    const { data, status } = await axiosInstance.get(renderUrl)
-    if (status !== 200 || data.responseCode !== 0) {
-      throw new Error(`SMS request failed. Body: ${JSON.stringify(data)}`)
-    }
-    return this.postSimulationResultsSms(data.messageIds[0])
+    const messageId = await renderAndSendSimulationResultsSms(this)
+    return this.postSimulationResultsSms(messageId)
   } catch (err) {
     this.smsError = JSON.stringify(err, null, 2)
     throw err