Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remplace le selecteur de couleur #2218

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Remplace le selecteur de couleur #2218

merged 1 commit into from
Aug 23, 2022

Conversation

mquandalle
Copy link
Contributor

@mquandalle mquandalle commented Jul 20, 2022

La PR faisait initialement une MAJ de vitejs vers la version 3 mais j'ai un problème avec le bundle SSR en ESModule.

J'ai essayé de repasser en bundle SSR CommonJS via l'option ssr.format de vite, le bundle est bien généré mais il y a une nouvelle erreur incompréhensible qui semble liée au SSR de react-dom/server (j'ai tenté la MAJ vers react 18 mais le problème est toujours présent)

/home/mquandalle/github/mon-entreprise/site/dist/server/entry-server.cjs:5460
        ctor.prototype = Object.create(superCtor.prototype, {
                                ^
TypeError [Error]: Object prototype may only be an Object or null: undefined
    at Function.create (<anonymous>)
    at inherits2 (/home/mquandalle/github/mon-entreprise/site/dist/server/entry-server.cjs:5460:33)
    at require_stream_readable (/home/mquandalle/github/mon-entreprise/site/dist/server/entry-server.cjs:7285:20)
    at /home/mquandalle/github/mon-entreprise/site/dist/server/entry-server.cjs:8829:36
    at requireReadable (/home/mquandalle/github/mon-entreprise/site/dist/server/entry-server.cjs:8839:5)
    at /home/mquandalle/github/mon-entreprise/site/dist/server/entry-server.cjs:12193:21
    at requireReactDomServerLegacy_node_development (/home/mquandalle/github/mon-entreprise/site/dist/server/entry-server.cjs:17457:7)
    at Module.<anonymous> (/home/mquandalle/github/mon-entreprise/site/dist/server/entry-server.cjs:22740:9)

Je n'ai pas envie de passer plus de temps sur ces problèmes de comptabilité, je garde seulement mon commit qui changait le selecteur de couleur et on verra plus tard pour ces histoires de modules SSR.

@mquandalle
Copy link
Contributor Author

Encore un bug CommonJS / ESM... Cette fois-ci j'ai l'impression que ça vient de react-aria adobe/react-spectrum#2881

@mquandalle mquandalle force-pushed the vite3 branch 2 times, most recently from f258ed4 to a5333de Compare August 2, 2022 10:29
@github-actions github-actions bot temporarily deployed to 2218 August 2, 2022 10:39 Inactive
@github-actions github-actions bot temporarily deployed to 2218 August 2, 2022 10:39 Inactive
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

@mquandalle mquandalle changed the title MAJ Vite Vitest Remplace le selecteur de couleur Aug 23, 2022
@github-actions github-actions bot temporarily deployed to 2218 August 23, 2022 10:32 Inactive
@mquandalle mquandalle merged commit cb683f0 into master Aug 23, 2022
@mquandalle mquandalle deleted the vite3 branch August 23, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant