Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use source detecetors names as Dataset name #7

Merged
merged 5 commits into from
May 4, 2023

Conversation

johnoppenheimer
Copy link
Collaborator

Update of HDF5 attributes and dataset names.

Copy link
Collaborator

@wiwski wiwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top pour le renommage et l'ajout des attributs 👍

Faudrait juste faire un check avec Claire et Léa si ça leur convient le nom "_filter" pour les données agrégées.

J'ai ajouté un commentaire pour un test sinon le reste me semble niquel !

src/converter/helpers.rs Outdated Show resolved Hide resolved
@johnoppenheimer johnoppenheimer merged commit 40981cf into main May 4, 2023
@johnoppenheimer johnoppenheimer deleted the feature/acq_time branch May 4, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants